Commit 38a94195 authored by Nico Weber's avatar Nico Weber

Add a few FALLTHROUGH annotations, and fix a missing break in video_color_space.cc

TBR=danakj

Bug: 177475
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4278dac80badb5768e725986f6a32b11ca244507
Reviewed-on: https://chromium-review.googlesource.com/886882
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatardanakj <danakj@chromium.org>
Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531996}
parent 0517d819
...@@ -376,7 +376,7 @@ bool PaintShader::IsValid() const { ...@@ -376,7 +376,7 @@ bool PaintShader::IsValid() const {
start_degrees_ >= end_degrees_) { start_degrees_ >= end_degrees_) {
return false; return false;
} }
// Fallthrough. FALLTHROUGH;
case Type::kLinearGradient: case Type::kLinearGradient:
case Type::kRadialGradient: case Type::kRadialGradient:
case Type::kTwoPointConicalGradient: case Type::kTwoPointConicalGradient:
...@@ -428,7 +428,7 @@ bool PaintShader::operator==(const PaintShader& other) const { ...@@ -428,7 +428,7 @@ bool PaintShader::operator==(const PaintShader& other) const {
return false; return false;
if (!PaintOp::AreEqualEvenIfNaN(end_degrees_, other.end_degrees_)) if (!PaintOp::AreEqualEvenIfNaN(end_degrees_, other.end_degrees_))
return false; return false;
// Fallthrough. FALLTHROUGH;
case Type::kLinearGradient: case Type::kLinearGradient:
case Type::kRadialGradient: case Type::kRadialGradient:
case Type::kTwoPointConicalGradient: case Type::kTwoPointConicalGradient:
......
...@@ -575,6 +575,7 @@ bool MimeUtil::IsCodecSupportedOnAndroid( ...@@ -575,6 +575,7 @@ bool MimeUtil::IsCodecSupportedOnAndroid(
// valid codecs to be used with HLS mime types. // valid codecs to be used with HLS mime types.
DCHECK(!base::EndsWith(mime_type_lower_case, "mpegurl", DCHECK(!base::EndsWith(mime_type_lower_case, "mpegurl",
base::CompareCase::SENSITIVE)); base::CompareCase::SENSITIVE));
FALLTHROUGH;
case PCM: case PCM:
case MP3: case MP3:
case MPEG4_AAC: case MPEG4_AAC:
......
...@@ -104,6 +104,7 @@ gfx::ColorSpace VideoColorSpace::ToGfxColorSpace() const { ...@@ -104,6 +104,7 @@ gfx::ColorSpace VideoColorSpace::ToGfxColorSpace() const {
break; break;
case PrimaryID::SMPTEST432_1: case PrimaryID::SMPTEST432_1:
primary_id = gfx::ColorSpace::PrimaryID::SMPTEST432_1; primary_id = gfx::ColorSpace::PrimaryID::SMPTEST432_1;
break;
case PrimaryID::EBU_3213_E: case PrimaryID::EBU_3213_E:
// TODO(uzair.jaleel) Need to check this once. // TODO(uzair.jaleel) Need to check this once.
primary_id = gfx::ColorSpace::PrimaryID::INVALID; primary_id = gfx::ColorSpace::PrimaryID::INVALID;
......
...@@ -830,7 +830,7 @@ size_t VideoFrame::BitDepth() const { ...@@ -830,7 +830,7 @@ size_t VideoFrame::BitDepth() const {
switch (format_) { switch (format_) {
case media::PIXEL_FORMAT_UNKNOWN: case media::PIXEL_FORMAT_UNKNOWN:
NOTREACHED(); NOTREACHED();
// Fall through! FALLTHROUGH;
case media::PIXEL_FORMAT_I420: case media::PIXEL_FORMAT_I420:
case media::PIXEL_FORMAT_YV12: case media::PIXEL_FORMAT_YV12:
case media::PIXEL_FORMAT_I422: case media::PIXEL_FORMAT_I422:
......
...@@ -101,6 +101,7 @@ static VideoPixelFormat AomImgFmtToVideoPixelFormat(const aom_image_t* img) { ...@@ -101,6 +101,7 @@ static VideoPixelFormat AomImgFmtToVideoPixelFormat(const aom_image_t* img) {
// TODO(dalecurtis): We'll need to add support for these to handle the // TODO(dalecurtis): We'll need to add support for these to handle the
// full range of expected AOM content. // full range of expected AOM content.
NOTIMPLEMENTED(); NOTIMPLEMENTED();
break;
default: default:
break; break;
......
...@@ -407,7 +407,7 @@ void GpuVideoDecoder::Decode(const scoped_refptr<DecoderBuffer>& buffer, ...@@ -407,7 +407,7 @@ void GpuVideoDecoder::Decode(const scoped_refptr<DecoderBuffer>& buffer,
switch (state_) { switch (state_) {
case kDecoderDrained: case kDecoderDrained:
state_ = kNormal; state_ = kNormal;
// Fall-through. FALLTHROUGH;
case kNormal: case kNormal:
break; break;
case kDrainingDecoder: case kDrainingDecoder:
......
...@@ -203,6 +203,7 @@ class GestureProvider::GestureListenerImpl : public ScaleGestureListener, ...@@ -203,6 +203,7 @@ class GestureProvider::GestureListenerImpl : public ScaleGestureListener,
// which case the press should simply be dropped. // which case the press should simply be dropped.
if (pinch_event_sent_ || scroll_event_sent_) if (pinch_event_sent_ || scroll_event_sent_)
return; return;
break;
default: default:
break; break;
}; };
......
...@@ -79,6 +79,7 @@ GestureEventDetails::GestureEventDetails(ui::EventType type, ...@@ -79,6 +79,7 @@ GestureEventDetails::GestureEventDetails(ui::EventType type,
// allowed as an exception. // allowed as an exception.
if (other.type() == ui::ET_GESTURE_PINCH_BEGIN) if (other.type() == ui::ET_GESTURE_PINCH_BEGIN)
break; break;
FALLTHROUGH;
case ui::ET_GESTURE_SCROLL_UPDATE: case ui::ET_GESTURE_SCROLL_UPDATE:
case ui::ET_SCROLL_FLING_START: case ui::ET_SCROLL_FLING_START:
case ui::ET_GESTURE_SWIPE: case ui::ET_GESTURE_SWIPE:
......
...@@ -96,6 +96,7 @@ bool MotionEventAura::OnTouch(const TouchEvent& touch) { ...@@ -96,6 +96,7 @@ bool MotionEventAura::OnTouch(const TouchEvent& touch) {
case ET_TOUCH_PRESSED: case ET_TOUCH_PRESSED:
if (!AddTouch(touch)) if (!AddTouch(touch))
return false; return false;
FALLTHROUGH;
case ET_TOUCH_RELEASED: case ET_TOUCH_RELEASED:
case ET_TOUCH_CANCELLED: case ET_TOUCH_CANCELLED:
// Removing these touch points needs to be postponed until after the // Removing these touch points needs to be postponed until after the
......
...@@ -635,6 +635,7 @@ int GetChangedMouseButtonFlagsFromXEvent(const XEvent& xev) { ...@@ -635,6 +635,7 @@ int GetChangedMouseButtonFlagsFromXEvent(const XEvent& xev) {
default: default:
break; break;
} }
break;
} }
default: default:
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment