Skip to content

GitLab

T
tangled
Commit 397a12c2 authored by Peter Wen's avatar Peter Wen Committed by Commit Bot
Browse files
Options

Android: Use lint-baseline.xml for old todos 

As recommended in the lint README, lint-suppressions.xml should only be
used for temporary and permanent ignores, not for old code that should
be fixed at some point:
https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md

Thus, bulk-moving ignores for old code into lint-baseline.xml.

The one exception is for UnusedResources, since having these checks in
lint-baseline.xml causes a lot of bloat in terms of lines since each
language's xml file is listed on a separate line for every resource.

Bug: 1069186, 1077861, 1116130, 1085410, 1039415
Fixed: 1069186, 1085410
Change-Id: Iac10f4dc087e12b43595aae154dc7ffb821f2325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552853
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829920}
parent cc69aaea
Hide whitespace changes
Inline Side-by-side
Showing with 97 additions and 194 deletions
build/android/docs/lint.md
View file @ 397a12c2
......@@ -86,6 +86,11 @@ targets, add the warning to the `_DISABLED_ALWAYS` list in
[build/android/gyp/lint.py](https://source.chromium.org/chromium/chromium/src/+/master:build/android/gyp/lint.py).
Disabling globally makes lint a bit faster.
The exception to the above rule is for warnings that affect multiple languages.
Feel free to suppress those in lint-suppressions.xml files since it is not
practical to suppress them in each language file and it is a lot of extra bloat
to list out every language for every violation in lint-baseline.xml files.
Here is an example of how to structure a suppressions XML file:
```xml
......
chrome/android/expectations/lint-baseline.xml
View file @ 397a12c2
......@@ -173,7 +173,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java"
line="463"
line="422"
column="30"/>
</issue>
......@@ -195,7 +195,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="1347"
line="1348"
column="9"/>
</issue>
......@@ -206,7 +206,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="1348"
line="1349"
column="17"/>
</issue>
......@@ -217,7 +217,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="1844"
line="1845"
column="46"/>
</issue>
......@@ -228,7 +228,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/java/src/org/chromium/android_webview/AwContents.java"
line="2843"
line="2840"
column="22"/>
</issue>
......@@ -305,7 +305,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java"
line="135"
line="144"
column="36"/>
</issue>
......@@ -316,7 +316,7 @@
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ui/BottomSheetManager.java"
line="224"
line="236"
column="55"/>
</issue>
......@@ -327,7 +327,7 @@
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ui/BottomSheetManager.java"
line="228"
line="240"
column="48"/>
</issue>
......@@ -338,7 +338,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../weblayer/browser/java/org/chromium/weblayer_private/BrowserImpl.java"
line="305"
line="300"
column="57"/>
</issue>
......@@ -349,7 +349,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../weblayer/browser/java/org/chromium/weblayer_private/BrowserImpl.java"
line="416"
line="411"
column="77"/>
</issue>
......@@ -360,7 +360,7 @@
errorLine2=" ~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java"
line="367"
line="364"
column="84"/>
</issue>
......@@ -371,7 +371,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java"
line="757"
line="754"
column="23"/>
</issue>
......@@ -393,7 +393,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java"
line="791"
line="797"
column="67"/>
</issue>
......@@ -437,7 +437,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManagerImpl.java"
line="137"
line="138"
column="46"/>
</issue>
......@@ -448,7 +448,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManagerImpl.java"
line="143"
line="144"
column="46"/>
</issue>
......@@ -470,7 +470,7 @@
errorLine2=" ^">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/autofill/prefeditor/EditorDialog.java"
line="491"
line="504"
column="43"/>
</issue>
......@@ -481,7 +481,7 @@
errorLine2=" ~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/autofill/prefeditor/EditorDialog.java"
line="495"
line="508"
column="42"/>
</issue>
......@@ -547,7 +547,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java"
line="112"
line="111"
column="20"/>
</issue>
......@@ -558,7 +558,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java"
line="131"
line="130"
column="42"/>
</issue>
......@@ -569,7 +569,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java"
line="145"
line="144"
column="20"/>
</issue>
......@@ -650,39 +650,6 @@
column="50"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" dropdown = new OmniboxSuggestionsRecyclerView(context);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdownFactory.java"
line="38"
column="24"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" dropdown.setAdapter(adapter);"
errorLine2=" ~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdownFactory.java"
line="42"
column="18"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" dropdown = new OmniboxSuggestionsList(context);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdownFactory.java"
line="50"
column="24"/>
</issue>
<issue
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
......@@ -701,7 +668,7 @@
errorLine2=" ~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java"
line="515"
line="516"
column="22"/>
</issue>
......@@ -745,7 +712,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java"
line="477"
line="470"
column="52"/>
</issue>
......@@ -778,7 +745,7 @@
errorLine2=" ~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java"
line="327"
line="334"
column="20"/>
</issue>
......@@ -954,7 +921,7 @@
errorLine2=" ~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java"
line="1535"
line="1534"
column="74"/>
</issue>
......@@ -965,7 +932,7 @@
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarCoordinator.java"
line="626"
line="590"
column="31"/>
</issue>
......@@ -1064,7 +1031,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/messages/android/java/res/layout/message_banner_view.xml"
line="27"
line="31"
column="9"/>
</issue>
......@@ -1075,7 +1042,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../components/messages/android/java/res/layout/message_banner_view.xml"
line="56"
line="60"
column="9"/>
</issue>
......@@ -1442,6 +1409,17 @@
column="4"/>
</issue>
<issue
id="MergeRootFrame"
message="This `&lt;FrameLayout>` can be replaced with a `&lt;merge>` tag"
errorLine1="&lt;FrameLayout"
errorLine2="^">
<location
file="../../chrome/android/feed/core/java/resv1/layout/feed_more_button.xml"
line="7"
column="1"/>
</issue>
<issue
id="MergeRootFrame"
message="This `&lt;FrameLayout>` can be replaced with a `&lt;merge>` tag"
......@@ -1460,10 +1438,54 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/DropdownItemViewInfoListManager.java"
line="34"
line="35"
column="33"/>
</issue>
<issue
id="UsableSpace"
message="Consider also using `StorageManager#getAllocatableBytes` and `allocateBytes` which will consider clearable cached data"
errorLine1=" dir.getAbsolutePath(), dir.getUsableSpace(), dir.getTotalSpace(), type);"
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/DownloadDirectoryProvider.java"
line="152"
column="48"/>
</issue>
<issue
id="UsableSpace"
message="Consider also using `StorageManager#getAllocatableBytes` and `allocateBytes` which will consider clearable cached data"
errorLine1=" mFreeSpace = Environment.getExternalStorageDirectory().getUsableSpace();"
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/download/OMADownloadHandler.java"
line="317"
column="68"/>
</issue>
<issue
id="UsableSpace"
message="Consider also using `StorageManager#getAllocatableBytes` and `allocateBytes` which will consider clearable cached data"
errorLine1=" return Environment.getDataDirectory().getUsableSpace();"
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java"
line="240"
column="47"/>
</issue>
<issue
id="UsableSpace"
message="Consider also using `StorageManager#getAllocatableBytes` and `allocateBytes` which will consider clearable cached data"
errorLine1=" defaultDownloadDir.getAbsolutePath(), defaultDownloadDir.getUsableSpace(),"
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/home/storage/StorageSummaryProvider.java"
line="86"
column="82"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
......@@ -1504,7 +1526,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/accessibility_tab_switcher/AccessibilityTabModelListItem.java"
line="459"
line="458"
column="20"/>
</issue>
......@@ -1515,7 +1537,7 @@
errorLine2=" ^">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java"
line="193"
line="216"
column="46"/>
</issue>
......@@ -1526,7 +1548,7 @@
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java"
line="270"
line="283"
column="9"/>
</issue>
......@@ -1537,7 +1559,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../components/browser_ui/android/bottomsheet/internal/java/src/org/chromium/components/browser_ui/bottomsheet/BottomSheet.java"
line="275"
line="278"
column="20"/>
</issue>
......@@ -1592,7 +1614,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java"
line="660"
line="661"
column="20"/>
</issue>
......@@ -1713,7 +1735,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java"
line="111"
line="139"
column="20"/>
</issue>
......@@ -1823,7 +1845,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarControlContainer.java"
line="264"
line="261"
column="20"/>
</issue>
......@@ -1834,7 +1856,7 @@
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java"
line="488"
line="487"
column="20"/>
</issue>
......@@ -1904,94 +1926,6 @@
column="17"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_card_footer.xml"
line="14"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_generic_item.xml"
line="14"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_image_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_in_progress_image_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_in_progress_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_in_progress_video_item.xml"
line="12"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_prefetch_article.xml"
line="14"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/browser/download/android/java/res/layout/download_manager_video_item.xml"
line="13"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
......@@ -2025,17 +1959,6 @@
column="13"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../chrome/android/java/res/layout/share_sheet_item.xml"
line="9"
column="5"/>
</issue>
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
......
chrome/android/expectations/lint-suppressions.xml
View file @ 397a12c2
......@@ -54,10 +54,6 @@ https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.
<issue id="InvalidVectorPath" severity="ignore"/>
<issue id="LogConditional" severity="ignore"/>
<issue id="LongLogTag" severity="ignore"/>
<issue id="MergeRootFrame">
<!-- TODO(crbug.com/1039415): Remove suppression after fixing bug. -->
<ignore regexp="chrome/android/feed/core/java/resv1/layout/feed_more_button.xml"/>
</issue>
<issue id="MissingClass" severity="ignore"/>
<issue id="MissingDefaultResource">
<!-- Only used by ToolbarControlContainer guarded by tablet form-factor. -->
......@@ -68,10 +64,6 @@ https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.
<issue id="MissingPermission" severity="ignore"/>
<issue id="MissingQuantity" severity="ignore"/>
<issue id="MissingRegistered" severity="ignore"/>
<issue id="MissingSuperCall">
<!-- TODO(wnwen): File bug to fix -->
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectionToolbar.java"/>
</issue>
<issue id="MissingTranslation">
<ignore regexp="restriction_values.xml.*"/>
</issue>
......@@ -82,8 +74,6 @@ https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.
<ignore regexp="Static interface method requires API level 24"/>
<!-- 1: TaskInfo is refactored at API 29. -->
<ignore regexp="Field requires API level .*`android.app.TaskInfo"/>
<!-- 1: TODO(crbug.com/1085410): Fix -->
<ignore regexp="components/content_capture/android/java/src/org/chromium/components/content_capture"/>
<!-- Endnote: Please specify number of suppressions when adding more -->
</issue>
<!-- This warning just adds a lot of false positives. -->
......@@ -255,25 +245,17 @@ https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.
<ignore regexp="components/page_info/android/java/res/drawable-hdpi/pageinfo_*"/>
<!--TODO(crbug.com/1052375): Remove this suppression once PermissionParamsListBuilder moves to components.-->
<ignore regexp="The resource `R.string.page_info_permission_ads_subtitle` appears to be unused"/>
<!--TODO(crbug.com/1069186): The following 14 are found when we switched to linting the entire app. -->
<!--TODO(crbug.com/1069186): The following 10 are found when we switched to linting the entire app. -->
<ignore regexp="The resource `R.string.download_manager_ui_documents` appears to be unused"/>
<ignore regexp="The resource `R.string.download_manager_offline_home` appears to be unused"/>
<ignore regexp="The resource `R.string.ntp_learn_more_about_suggested_content` appears to be unused"/>
<ignore regexp="The resource `R.string.ntp_feed_menu_iph` appears to be unused"/>
<ignore regexp="The resource `R.string.tab_switcher_button_label` appears to be unused"/>
<ignore regexp="The resource `R.string.prefs_autofill_assistant_switch` appears to be unused"/>
<ignore regexp="The resource `R.string.storage_clear_dialog_text` appears to be unused"/>
<ignore regexp="The resource `R.string.website_settings_category_notifications_block` appears to be unused"/>
<ignore regexp="The resource `R.string.autofill_cc_google_issued` appears to be unused"/>
<ignore regexp="The resource `R.string.notification_manage_button` appears to be unused"/>
<ignore regexp="The resource `R.string.app_banner_add` appears to be unused"/>
<ignore regexp="The resource `R.string.notification_category_permission_requests` appears to be unused"/>
<ignore regexp="The resource `R.drawable.ic_launcher_background` appears to be unused"/>
<ignore regexp="The resource `R.string.combined_notification_text` appears to be unused"/>
<ignore regexp="The resource `R.plurals.public_notification_text` appears to be unused"/>
<ignore regexp="The resource `R.mipmap.app_shortcut_icon` appears to be unused"/>
<ignore regexp="The resource `R.string.app_banner_install` appears to be unused"/>
<ignore regexp="The resource `R.string.iph_download_indicator_text` appears to be unused"/>
<!--TODO(crbug.com/1106109): Remove this suppression once Most Visited Tiles header is implemented.-->
<ignore regexp="The resource `R.string.most_visited_tiles_header` appears to be unused"/>
<ignore regexp="The resource `R.string.accessibility_omnibox_showing_suggestions_for_website` appears to be unused"/>
......@@ -296,13 +278,6 @@ https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.
<ignore regexp="The resource `R.string.price_drop_spotted_show_me` appears to be unused"/>
<!-- Endnote: Please specify number of suppressions when adding more -->
</issue>
<issue id="UsableSpace">
<!-- TODO(crbug.com/1077861): Old code, good to fix. -->
<ignore regexp="chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/DownloadDirectoryProvider.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/download/OMADownloadHandler.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java"/>
<ignore regexp="chrome/browser/download/internal/android/java/src/org/chromium/chrome/browser/download/home/storage/StorageSummaryProvider.java"/>
</issue>
<issue id="VectorPath" severity="ignore"/>
<!-- These constructors are useful for layout editors which we currently do not support. -->
<issue id="ViewConstructor" severity="ignore"/>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment