Commit 39972621 authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Commit Bot

[base] Apply BindOnceRewriter in //base

This change applies the BindOnceRewriter in //base.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=brucedawson@chromium.org

Bug: 714018
Change-Id: I9b35e5f70260a892ed38255edd632699c293235b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132388Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755487}
parent a9b08483
...@@ -371,7 +371,7 @@ TEST_F(RegistryTest, ChangeCallback) { ...@@ -371,7 +371,7 @@ TEST_F(RegistryTest, ChangeCallback) {
key.Create(HKEY_CURRENT_USER, foo_key.c_str(), KEY_READ)); key.Create(HKEY_CURRENT_USER, foo_key.c_str(), KEY_READ));
ASSERT_TRUE(key.StartWatching( ASSERT_TRUE(key.StartWatching(
BindRepeating(&TestChangeDelegate::OnKeyChanged, Unretained(&delegate)))); BindOnce(&TestChangeDelegate::OnKeyChanged, Unretained(&delegate))));
EXPECT_FALSE(delegate.WasCalled()); EXPECT_FALSE(delegate.WasCalled());
// Make some change. // Make some change.
...@@ -389,7 +389,7 @@ TEST_F(RegistryTest, ChangeCallback) { ...@@ -389,7 +389,7 @@ TEST_F(RegistryTest, ChangeCallback) {
EXPECT_FALSE(delegate.WasCalled()); EXPECT_FALSE(delegate.WasCalled());
ASSERT_TRUE(key.StartWatching( ASSERT_TRUE(key.StartWatching(
BindRepeating(&TestChangeDelegate::OnKeyChanged, Unretained(&delegate)))); BindOnce(&TestChangeDelegate::OnKeyChanged, Unretained(&delegate))));
// Change something else. // Change something else.
EXPECT_EQ(ERROR_SUCCESS, key2.WriteValue(L"name2", L"data2")); EXPECT_EQ(ERROR_SUCCESS, key2.WriteValue(L"name2", L"data2"));
...@@ -397,7 +397,7 @@ TEST_F(RegistryTest, ChangeCallback) { ...@@ -397,7 +397,7 @@ TEST_F(RegistryTest, ChangeCallback) {
ASSERT_TRUE(delegate.WasCalled()); ASSERT_TRUE(delegate.WasCalled());
ASSERT_TRUE(key.StartWatching( ASSERT_TRUE(key.StartWatching(
BindRepeating(&TestChangeDelegate::OnKeyChanged, Unretained(&delegate)))); BindOnce(&TestChangeDelegate::OnKeyChanged, Unretained(&delegate))));
RunLoop().RunUntilIdle(); RunLoop().RunUntilIdle();
EXPECT_FALSE(delegate.WasCalled()); EXPECT_FALSE(delegate.WasCalled());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment