Init members in declaration where possible in various download classes.

Complies with
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#initialize-members-in-the-declaration-where-possible

Bug: none
Change-Id: Ie5d21f9bf83bb1dae3ddd9e85b1a0e332687e6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347200
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797134}

chrome/browser/download/download_shelf.cc

@@ -41,10 +41,7 @@ const int64_t kDownloadShowDelayInSeconds = 2;
 }  // namespace
 
 DownloadShelf::DownloadShelf(Browser* browser, Profile* profile)
-    : browser_(browser),
-      profile_(profile),
-      should_show_on_unhide_(false),
-      is_hidden_(false) {}
+    : browser_(browser), profile_(profile) {}
 
 DownloadShelf::~DownloadShelf() {}
 

chrome/browser/download/download_shelf.h

@@ -97,8 +97,8 @@ class DownloadShelf {
 
   Browser* const browser_;
   Profile* const profile_;
-  bool should_show_on_unhide_;
-  bool is_hidden_;
+  bool should_show_on_unhide_ = false;
+  bool is_hidden_ = false;
   base::WeakPtrFactory<DownloadShelf> weak_ptr_factory_{this};
 };
 

chrome/browser/download/test_download_shelf.cc

@@ -7,9 +7,7 @@
 #include "content/public/browser/download_manager.h"
 
 TestDownloadShelf::TestDownloadShelf(Profile* profile)
-    : DownloadShelf(nullptr, profile),
-      is_showing_(false),
-      did_add_download_(false) {}
+    : DownloadShelf(nullptr, profile) {}
 
 TestDownloadShelf::~TestDownloadShelf() = default;
 

chrome/browser/download/test_download_shelf.h

@@ -36,8 +36,8 @@ class TestDownloadShelf : public DownloadShelf {
   base::TimeDelta GetTransientDownloadShowDelay() const override;
 
  private:
-  bool is_showing_;
-  bool did_add_download_;
+  bool is_showing_ = false;
+  bool did_add_download_ = false;
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_TEST_DOWNLOAD_SHELF_H_

chrome/browser/ui/views/download/download_shelf_view.cc

@@ -36,7 +36,6 @@
 #include "ui/views/controls/button/image_button_factory.h"
 #include "ui/views/controls/button/md_text_button.h"
 #include "ui/views/controls/link.h"
-#include "ui/views/mouse_watcher_view_host.h"
 
 using download::DownloadItem;
 
@@ -61,12 +60,7 @@ constexpr int kCloseAndLinkPadding = 6;
 DownloadShelfView::DownloadShelfView(Browser* browser, BrowserView* parent)
     : DownloadShelf(browser, browser->profile()),
       AnimationDelegateViews(this),
-      new_item_animation_(this),
-      shelf_animation_(this),
-      parent_(parent),
-      mouse_watcher_(
-          std::make_unique<views::MouseWatcherViewHost>(this, gfx::Insets()),
-          this) {
+      parent_(parent) {
   // Start out hidden: the shelf might be created but never shown in some
   // cases, like when installing a theme. See DownloadShelf::AddDownload().
   SetVisible(false);

chrome/browser/ui/views/download/download_shelf_view.h

@@ -5,14 +5,17 @@
 #ifndef CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_
 
+#include <memory>
 #include <vector>
 
 #include "chrome/browser/download/download_shelf.h"
 #include "ui/gfx/animation/slide_animation.h"
+#include "ui/gfx/geometry/insets.h"
 #include "ui/views/accessible_pane_view.h"
 #include "ui/views/animation/animation_delegate_views.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/mouse_watcher.h"
+#include "ui/views/mouse_watcher_view_host.h"
 
 class Browser;
 class BrowserView;
@@ -85,17 +88,17 @@ class DownloadShelfView : public DownloadShelf,
   FRIEND_TEST_ALL_PREFIXES(DownloadShelfViewTest, ShowAllViewColors);
 
   // The animation for adding new items to the shelf.
-  gfx::SlideAnimation new_item_animation_;
+  gfx::SlideAnimation new_item_animation_{this};
 
   // The show/hide animation for the shelf itself.
-  gfx::SlideAnimation shelf_animation_;
+  gfx::SlideAnimation shelf_animation_{this};
 
   // The download views. These are also child Views, and deleted when
   // the DownloadShelfView is deleted.
   std::vector<DownloadItemView*> download_views_;
 
   // Button for showing all downloads (chrome://downloads).
-  views::MdTextButton* show_all_view_ = nullptr;
+  views::MdTextButton* show_all_view_;
 
   // Button for closing the downloads. This is contained as a child, and
   // deleted by View.
@@ -108,7 +111,8 @@ class DownloadShelfView : public DownloadShelf,
   // The window this shelf belongs to.
   BrowserView* parent_;
 
-  views::MouseWatcher mouse_watcher_;
+  views::MouseWatcher mouse_watcher_{
+      std::make_unique<views::MouseWatcherViewHost>(this, gfx::Insets()), this};
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_DOWNLOAD_DOWNLOAD_SHELF_VIEW_H_