Commit 3a4e7304 authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

Fix bubble presentation for non-UI refresh

The bubble presentation of UI Refresh tips in non-UI Refresh app should
be a no-op.

Bug: 869400
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I308c2a5dee2088af8b6ca56567a7089944f8bf34
Reviewed-on: https://chromium-review.googlesource.com/1156694
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: default avataredchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579904}
parent 24f50a1f
...@@ -173,6 +173,9 @@ const CGFloat kBubblePresentationDelay = 1; ...@@ -173,6 +173,9 @@ const CGFloat kBubblePresentationDelay = 1;
} }
- (void)presentLongPressBubble { - (void)presentLongPressBubble {
if (!IsUIRefreshPhase1Enabled())
return;
if (self.longPressToolbarTipBubblePresenter.isUserEngaged) if (self.longPressToolbarTipBubblePresenter.isUserEngaged)
return; return;
...@@ -231,7 +234,7 @@ presentBubbleForFeature:(const base::Feature&)feature ...@@ -231,7 +234,7 @@ presentBubbleForFeature:(const base::Feature&)feature
// Presents a bubble associated with the bottom toolbar tip in-product help // Presents a bubble associated with the bottom toolbar tip in-product help
// promotion. This method requires that |self.browserState| is not NULL. // promotion. This method requires that |self.browserState| is not NULL.
- (void)presentBottomToolbarTipBubble { - (void)presentBottomToolbarTipBubble {
if (!IsSplitToolbarMode()) if (!IsUIRefreshPhase1Enabled() || !IsSplitToolbarMode())
return; return;
if (![self canPresentBubble]) if (![self canPresentBubble])
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment