Commit 3a80e999 authored by bnc's avatar bnc Committed by Commit bot

Fix off-by-one in SpdyFramer.

Fix off-by-one in SpdyFramer::GetNumberRequiredContinuationFrames().

BUG=464748

Review URL: https://codereview.chromium.org/989283002

Cr-Commit-Position: refs/heads/master@{#319684}
parent 5953fcd5
......@@ -2968,7 +2968,9 @@ size_t SpdyFramer::GetNumberRequiredContinuationFrames(size_t size) {
DCHECK_GT(protocol_version(), SPDY3);
DCHECK_GT(size, kMaxControlFrameSize);
size_t overflow = size - kMaxControlFrameSize;
return overflow / (kMaxControlFrameSize - GetContinuationMinimumSize()) + 1;
size_t payload_size = kMaxControlFrameSize - GetContinuationMinimumSize();
// This is ceiling(overflow/payload_size) using integer arithmetics.
return (overflow - 1) / payload_size + 1;
}
void SpdyFramer::WritePayloadWithContinuation(SpdyFrameBuilder* builder,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment