Commit 3a9c76bf authored by nednguyen's avatar nednguyen Committed by Commit bot

Remove protected-access from tools/perf/pylintrc.

BUG=475714

Review URL: https://codereview.chromium.org/1103273002

Cr-Commit-Position: refs/heads/master@{#327078}
parent 8a134821
...@@ -232,6 +232,7 @@ class PageCyclerOopifTypical25(_PageCycler): ...@@ -232,6 +232,7 @@ class PageCyclerOopifTypical25(_PageCycler):
def CreatePageSet(self, options): def CreatePageSet(self, options):
return page_sets.Typical25PageSet(run_no_page_interactions=True) return page_sets.Typical25PageSet(run_no_page_interactions=True)
@benchmark.Disabled # crbug.com/443730 @benchmark.Disabled # crbug.com/443730
class PageCyclerBigJs(_PageCycler): class PageCyclerBigJs(_PageCycler):
page_set = page_sets.BigJsPageSet page_set = page_sets.BigJsPageSet
......
...@@ -63,7 +63,6 @@ class OilpanGCTimesTestData(object): ...@@ -63,7 +63,6 @@ class OilpanGCTimesTestData(object):
def ClearResults(self): def ClearResults(self):
self._results = page_test_results.PageTestResults() self._results = page_test_results.PageTestResults()
class OilpanGCTimesTest(page_test_test_case.PageTestTestCase): class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
"""Smoke test for Oilpan GC pause time measurements. """Smoke test for Oilpan GC pause time measurements.
...@@ -80,6 +79,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase): ...@@ -80,6 +79,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
def setUp(self): def setUp(self):
self._options = options_for_unittests.GetCopy() self._options = options_for_unittests.GetCopy()
# Disable for accessing private API of _OilpanGCTimesBase.
# pylint: disable=protected-access
def testForParsingOldFormat(self): def testForParsingOldFormat(self):
def getMetric(results, name): def getMetric(results, name):
metrics = results.FindAllPageSpecificValuesNamed(name) metrics = results.FindAllPageSpecificValuesNamed(name)
...@@ -109,6 +110,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase): ...@@ -109,6 +110,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
self.assertEquals(2, len(getMetric(results, self.assertEquals(2, len(getMetric(results,
'oilpan_forced_complete_sweep'))) 'oilpan_forced_complete_sweep')))
# Disable for accessing private API of _OilpanGCTimesBase.
# pylint: disable=protected-access
def testForParsing(self): def testForParsing(self):
def getMetric(results, name): def getMetric(results, name):
metrics = results.FindAllPageSpecificValuesNamed(name) metrics = results.FindAllPageSpecificValuesNamed(name)
......
...@@ -25,6 +25,8 @@ class TestTaskExecutionTimePage(page_module.Page): ...@@ -25,6 +25,8 @@ class TestTaskExecutionTimePage(page_module.Page):
action_runner.ScrollPage() action_runner.ScrollPage()
# Disable for accessing private API of task_execution_time.
# pylint: disable=protected-access
class TaskExecutionTimeUnitTest(page_test_test_case.PageTestTestCase): class TaskExecutionTimeUnitTest(page_test_test_case.PageTestTestCase):
def setUp(self): def setUp(self):
......
...@@ -169,6 +169,7 @@ def _FindV8EventStatForEvent(v8_event_stats_list, event_name): ...@@ -169,6 +169,7 @@ def _FindV8EventStatForEvent(v8_event_stats_list, event_name):
def _ParentIdleTask(event): def _ParentIdleTask(event):
parent = event.parent_slice parent = event.parent_slice
while parent: while parent:
# pylint: disable=protected-access
if parent.name == V8GCTimes._IDLE_TASK_PARENT: if parent.name == V8GCTimes._IDLE_TASK_PARENT:
return parent return parent
parent = parent.parent_slice parent = parent.parent_slice
......
...@@ -46,6 +46,7 @@ class V8GCTimesTestPageHelper(object): ...@@ -46,6 +46,7 @@ class V8GCTimesTestPageHelper(object):
results.WillRunPage(page) results.WillRunPage(page)
v8_gc_times_metric = v8_gc_times.V8GCTimes() v8_gc_times_metric = v8_gc_times.V8GCTimes()
# pylint: disable=protected-access
v8_gc_times_metric._renderer_process = self._renderer_process v8_gc_times_metric._renderer_process = self._renderer_process
# Finalize the timeline import. # Finalize the timeline import.
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
# Disable the message, report, category or checker with the given id(s). # Disable the message, report, category or checker with the given id(s).
# TODO(perf-owners): Reduce this list to as small as possible. # TODO(perf-owners): Reduce this list to as small as possible.
disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous-backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indentation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecated-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-redefined,global-statement,interface-not-implemented,invalid-name,locally-enabled,logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-name-in-module,no-self-use,no-self-use,not-callable,old-style-class,protected-access,reimported,star-args,super-on-old-class,superfluous-parens,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-public-methods,too-many-return-statements,too-many-statements,trailing-whitespace,unnecessary-semicolon,unpacking-non-sequence,useless-else-on-loop,unused-argument disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous-backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indentation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecated-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-redefined,global-statement,interface-not-implemented,invalid-name,locally-enabled,logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-name-in-module,no-self-use,no-self-use,not-callable,old-style-class,reimported,star-args,super-on-old-class,superfluous-parens,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-public-methods,too-many-return-statements,too-many-statements,trailing-whitespace,unnecessary-semicolon,unpacking-non-sequence,useless-else-on-loop,unused-argument
[REPORTS] [REPORTS]
......
...@@ -6,6 +6,8 @@ import unittest ...@@ -6,6 +6,8 @@ import unittest
import update_reference_build as update_ref_build import update_reference_build as update_ref_build
# Disable for accessing private API of update_reference_build class.
# pylint: disable=protected-access
class UpdateReferenceBuildUnittest(unittest.TestCase): class UpdateReferenceBuildUnittest(unittest.TestCase):
def testInit(self): def testInit(self):
@classmethod @classmethod
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment