Commit 3b966a9e authored by earthdok's avatar earthdok Committed by Commit bot

Address review comments for r322149 (package script for instrumented libs).

I accidentally landed the wrong patchset. :(

BUG=462636
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1004683003

Cr-Commit-Position: refs/heads/master@{#322150}
parent b251b58b
...@@ -30,33 +30,37 @@ function build_libraries { ...@@ -30,33 +30,37 @@ function build_libraries {
esac esac
local archive_name=${build_type}-${ubuntu_release} local archive_name=${build_type}-${ubuntu_release}
local out_dir=out_${archive_name} local out_dir=out-${archive_name}
echo "Building instrumented libraries in ${out_dir}..." echo "Building instrumented libraries in ${out_dir}..."
rm -rf $out_dir rm -rf $out_dir
mkdir $out_dir mkdir $out_dir
GYP_DEFINES="${gyp_defines} use_instrumented_libraries=1 instrumented_libraries_jobs=8" \ GYP_DEFINES="${gyp_defines} \
use_instrumented_libraries=1 instrumented_libraries_jobs=8" \
GYP_GENERATOR_FLAGS="output_dir=${out_dir}" \ GYP_GENERATOR_FLAGS="output_dir=${out_dir}" \
gclient runhooks gclient runhooks
ninja -C ${out_dir}/Release instrumented_libraries ninja -j4 -C ${out_dir}/Release instrumented_libraries
echo "Creating archive ${archive_name}.tgz..." echo "Creating archive ${archive_name}.tgz..."
files=$(ls -1 ${out_dir}/Release/instrumented_libraries) files=$(ls -1 ${out_dir}/Release/instrumented_libraries)
tar zcf ${archive_name}.tgz -C ${out_dir}/Release/instrumented_libraries --exclude="?san/*.txt" ${files} tar zcf ${archive_name}.tgz -C ${out_dir}/Release/instrumented_libraries \
--exclude="?san/*.txt" ${files}
echo To upload, run: echo To upload, run:
echo upload_to_google_storage.py -b chromium-instrumented-libraries ${archive_name}.tgz echo upload_to_google_storage.py -b \
chromium-instrumented-libraries ${archive_name}.tgz
echo You should then commit the resulting .sha1 file. echo You should then commit the resulting .sha1 file.
} }
if ! [[ "${supported_releases}" =~ ${ubuntu_release} ]] if ! [[ "${supported_releases}" =~ ${ubuntu_release} ]]
then then
echo "Unsupported Ubuntu release: ${ubuntu_release}" echo "Unsupported Ubuntu release: ${ubuntu_release}"
echo "Supported releases: ${supported_releases}"
exit 1 exit 1
fi fi
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment