Commit 3d279e08 authored by emircan's avatar emircan Committed by Commit bot

Limit VTVideoEncodeAccelerator keyframe output

On Macbook Air 2013, letting this be default results in a keyframe every ~5
seconds. This is too often for some applications. This CL changes this limit
so that max keyframe interval is 4 minutes.

BUG=658429
TEST=AppRTC loopback on Mac.

Review-Url: https://codereview.chromium.org/2431223011
Cr-Commit-Position: refs/heads/master@{#427143}
parent 004926e6
......@@ -560,6 +560,14 @@ bool VTVideoEncodeAccelerator::ConfigureCompressionSession() {
rv &= session_property_setter.Set(
videotoolbox_glue_->kVTCompressionPropertyKey_AllowFrameReordering(),
false);
// Limit keyframe output to 4 minutes, see crbug.com/658429.
rv &= session_property_setter.Set(
videotoolbox_glue_->kVTCompressionPropertyKey_MaxKeyFrameInterval(),
7200);
rv &= session_property_setter.Set(
videotoolbox_glue_
->kVTCompressionPropertyKey_MaxKeyFrameIntervalDuration(),
240);
DLOG_IF(ERROR, !rv) << " Setting session property failed.";
return rv;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment