Replaced RefPtr::release with std::move in Source/platform.

Part of the removal of PassRefPtr.

Replaces many of the calls to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, most methods still expect a PassRefPtr and so the PassRefPtr
initialising constructor will be called passing in the RefPtr rvalue,
which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719

Review-Url: https://codereview.chromium.org/2628773002
Cr-Commit-Position: refs/heads/master@{#443416}

third_party/WebKit/Source/platform/blob/BlobData.cpp

@@ -156,7 +156,7 @@ void BlobData::appendText(const String& text,
   }
 
   if (data)
-    m_items.push_back(BlobDataItem(data.release()));
+    m_items.push_back(BlobDataItem(std::move(data)));
 }
 
 void BlobData::appendBytes(const void* bytes, size_t length) {
@@ -170,7 +170,7 @@ void BlobData::appendBytes(const void* bytes, size_t length) {
   RefPtr<RawData> data = RawData::create();
   Vector<char>* buffer = data->mutableData();
   buffer->append(static_cast<const char*>(bytes), length);
-  m_items.push_back(BlobDataItem(data.release()));
+  m_items.push_back(BlobDataItem(std::move(data)));
 }
 
 long long BlobData::length() const {

third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

@@ -139,7 +139,7 @@ WebURLLoadTiming WebURLResponse::loadTiming() {
 void WebURLResponse::setLoadTiming(const WebURLLoadTiming& timing) {
   RefPtr<ResourceLoadTiming> loadTiming =
       PassRefPtr<ResourceLoadTiming>(timing);
-  m_resourceResponse->setResourceLoadTiming(loadTiming.release());
+  m_resourceResponse->setResourceLoadTiming(std::move(loadTiming));
 }
 
 WebHTTPLoadInfo WebURLResponse::httpLoadInfo() {

third_party/WebKit/Source/platform/fonts/FontFamily.h

@@ -76,7 +76,7 @@ inline bool operator!=(const FontFamily& a, const FontFamily& b) {
 }
 
 inline FontFamily::~FontFamily() {
-  RefPtr<SharedFontFamily> reaper = m_next.release();
+  RefPtr<SharedFontFamily> reaper = std::move(m_next);
   while (reaper && reaper->hasOneRef()) {
     // implicitly protects reaper->next, then derefs reaper
     reaper = reaper->releaseNext();
@@ -92,7 +92,7 @@ inline void FontFamily::appendFamily(PassRefPtr<SharedFontFamily> family) {
 }
 
 inline PassRefPtr<SharedFontFamily> FontFamily::releaseNext() {
-  return m_next.release();
+  return std::move(m_next);
 }
 
 }  // namespace blink

third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

@@ -74,7 +74,7 @@ static inline float shapeResultsForRun(
       totalWidth += wordResult->width();
       if (fallbackFonts)
         wordResult->fallbackFonts(fallbackFonts);
-      resultsBuffer->appendResult(wordResult.release());
+      resultsBuffer->appendResult(std::move(wordResult));
     }
   }
   return totalWidth;

third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

@@ -74,7 +74,7 @@ std::unique_ptr<DeferredImageDecoder> DeferredImageDecoder::create(
 
   // Since we've just instantiated a fresh decoder, there's no need to reset its
   // data.
-  decoder->setDataInternal(data.release(), dataComplete, false);
+  decoder->setDataInternal(std::move(data), dataComplete, false);
 
   return decoder;
 }
@@ -329,8 +329,8 @@ sk_sp<SkImage> DeferredImageDecoder::createFrameImageAtIndex(
       m_colorSpaceForSkImages);
 
   DecodingImageGenerator* generator = new DecodingImageGenerator(
-      m_frameGenerator, info, segmentReader.release(), m_allDataReceived, index,
-      m_frameData[index].m_uniqueID);
+      m_frameGenerator, info, std::move(segmentReader), m_allDataReceived,
+      index, m_frameData[index].m_uniqueID);
   sk_sp<SkImage> image = SkImage::MakeFromGenerator(
       generator);  // SkImage takes ownership of the generator.
   if (!image)

third_party/WebKit/Source/platform/graphics/ImageSource.cpp

@@ -52,7 +52,7 @@ bool ImageSource::setData(PassRefPtr<SharedBuffer> passData,
   m_allDataReceived = allDataReceived;
 
   if (m_decoder) {
-    m_decoder->setData(data.release(), allDataReceived);
+    m_decoder->setData(std::move(data), allDataReceived);
     // If the decoder is pre-instantiated, it means we've already validated the
     // data/signature at some point.
     return true;

third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp

@@ -66,7 +66,7 @@ class SkiaImageDecoder final : public SkImageDeserializer {
     RefPtr<SegmentReader> segmentReader =
         SegmentReader::createFromSkData(SkData::MakeWithoutCopy(data, length));
     std::unique_ptr<ImageDecoder> imageDecoder = ImageDecoder::create(
-        segmentReader.release(), true, ImageDecoder::AlphaPremultiplied,
+        std::move(segmentReader), true, ImageDecoder::AlphaPremultiplied,
         ColorBehavior::ignore());
     if (!imageDecoder)
       return nullptr;