Commit 3ee95a63 authored by Dominic Farolino's avatar Dominic Farolino Committed by Commit Bot

Remove DumpWithoutCrashing from the mojo traits file

It is no longer needed. This reverts the mojo traits changes from
https://crrev.com/c/2229205.

TBR=kinuko@chromium.org

Bug: 1090391,1091711
Change-Id: I93a38bc2351bbc1e5dffda040c7944271e01cde3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238901Reviewed-by: default avatarDominic Farolino <dom@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776840}
parent afaad7f4
......@@ -267,30 +267,4 @@ bool StructTraits<network::mojom::DataElementDataView, network::DataElement>::
return true;
}
// static
const GURL&
StructTraits<network::mojom::URLRequestDataView, network::ResourceRequest>::
referrer(const network::ResourceRequest& request) {
// TODO(crbug.com/1090391): Move this method back inline, and move the
// debugging logic back to NetworkServiceNetworkDelegate when the current
// cause of referrer mismatches is found.
if (request.referrer !=
net::URLRequestJob::ComputeReferrerForPolicy(
request.referrer_policy, request.referrer, request.url)) {
// Record information to help debug issues like http://crbug.com/422871.
if (request.url.SchemeIsHTTPOrHTTPS()) {
auto referrer_policy = request.referrer_policy;
base::debug::Alias(&referrer_policy);
DEBUG_ALIAS_FOR_GURL(target_buf, request.url);
DEBUG_ALIAS_FOR_GURL(referrer_buf, request.referrer);
DEBUG_ALIAS_FOR_GURL(
initiator_buf,
request.request_initiator.value_or(url::Origin()).GetURL())
base::debug::DumpWithoutCrashing();
}
}
return request.referrer;
}
} // namespace mojo
......@@ -9,7 +9,6 @@
#include <utility>
#include "base/component_export.h"
#include "base/debug/dump_without_crashing.h"
#include "base/memory/scoped_refptr.h"
#include "mojo/public/cpp/base/file_mojom_traits.h"
#include "mojo/public/cpp/base/file_path_mojom_traits.h"
......@@ -110,7 +109,9 @@ struct COMPONENT_EXPORT(NETWORK_CPP_BASE)
const network::ResourceRequest& request) {
return request.isolated_world_origin;
}
static const GURL& referrer(const network::ResourceRequest& request);
static const GURL& referrer(const network::ResourceRequest& request) {
return request.referrer;
}
static net::URLRequest::ReferrerPolicy referrer_policy(
const network::ResourceRequest& request) {
return request.referrer_policy;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment