Revert "service worker: Add detailed bad message error message for Register."

This reverts commit 66a6b0b0.

Reason for revert: This was a diagnostic for a crash bug that has been fixed, so it's no longer needed.

Original change's description:
> service worker: Add detailed bad message error message for Register.
> 
> We are getting crash reports about "kBadMessageImproperOrigins" from
> the Register message, so emit a more detailed message to help
> debugging.
> 
> These message are compact since there are only 256 characters
> available for bad message error messages.
> 
> Bug: 831255
> Change-Id: I932a78a625c92ffca626bb5b5dcb1128ecc623c0
> Reviewed-on: https://chromium-review.googlesource.com/1004892
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549850}

TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,shimazu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831255
Change-Id: Iea458ed43df35e63af83f8db99b03effd8276783
Reviewed-on: https://chromium-review.googlesource.com/1057027Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558224}

content/browser/service_worker/service_worker_provider_host.cc

@@ -144,28 +144,6 @@ ServiceWorkerMetrics::EventType PurposeToEventType(
   return ServiceWorkerMetrics::EventType::UNKNOWN;
 }
 
-// TODO(crbug/831255): Temporary debugging for the linked bug.
-std::string URLStringForBadMessage(const GURL& url) {
-  return url.possibly_invalid_spec().substr(0, 64);
-}
-
-// TODO(crbug/831255): Temporary debugging for the linked bug.
-std::string ProviderTypeStringForBadMessage(
-    blink::mojom::ServiceWorkerProviderType type) {
-  switch (type) {
-    case blink::mojom::ServiceWorkerProviderType::kUnknown:
-      return "unknown";
-    case blink::mojom::ServiceWorkerProviderType::kForSharedWorker:
-      return "shared";
-    case blink::mojom::ServiceWorkerProviderType::kForServiceWorker:
-      return "service";
-    case blink::mojom::ServiceWorkerProviderType::kForWindow:
-      return "window";
-  }
-  NOTREACHED();
-  return std::string();
-}
-
 }  // anonymous namespace
 
 // static
@@ -1092,41 +1070,17 @@ bool ServiceWorkerProviderHost::IsValidRegisterMessage(
     *out_error = ServiceWorkerConsts::kBadMessageFromNonWindow;
     return false;
   }
-  // TODO(crbug/831255): Temporary detailed messages for the linked bug.
-  // These message are compact since there are only 256 characters available.
-  const std::string provider_str =
-      ProviderTypeStringForBadMessage(provider_type());
-  std::stringstream stream;
-  if (!document_url_.is_valid()) {
-    stream << "SWPH_REGISTER_INVALID_DOCUMENT:" << provider_str
-           << "d=" << URLStringForBadMessage(document_url_);
-    *out_error = stream.str();
-    return false;
-  }
-  if (!options.scope.is_valid()) {
-    stream << "SWPH_REGISTER_INVALID_SCOPE:" << provider_str
-           << "p=" << URLStringForBadMessage(options.scope);
-    *out_error = stream.str();
-    return false;
-  }
-  if (!script_url.is_valid()) {
-    stream << "SWPH_REGISTER_INVALID_SCRIPT: " << provider_str
-           << "s=" << URLStringForBadMessage(script_url);
-    *out_error = stream.str();
+  if (!options.scope.is_valid() || !script_url.is_valid()) {
+    *out_error = ServiceWorkerConsts::kBadMessageInvalidURL;
     return false;
   }
-
   if (ServiceWorkerUtils::ContainsDisallowedCharacter(options.scope, script_url,
                                                       out_error)) {
     return false;
   }
-  std::vector<GURL> urls = {document_url_, options.scope, script_url};
+  std::vector<GURL> urls = {document_url(), options.scope, script_url};
   if (!ServiceWorkerUtils::AllOriginsMatchAndCanAccessServiceWorkers(urls)) {
-    stream << "SWPH_REGISTER:" << provider_str
-           << ",d=" << URLStringForBadMessage(document_url_)
-           << ",p=" << URLStringForBadMessage(options.scope)
-           << ",s=" << URLStringForBadMessage(script_url);
-    *out_error = stream.str();
+    *out_error = ServiceWorkerConsts::kBadMessageImproperOrigins;
     return false;
   }