Commit 3fb8f1d5 authored by Erik Staab's avatar Erik Staab Committed by Commit Bot

Convert headless to use BindOnce and BindRepeating.

Bug: 1007791
Change-Id: Ia2eee33ff64d82c3a18abf217d1edc51a225363d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932236Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718909}
parent dce10d93
...@@ -775,7 +775,7 @@ int HeadlessShellMain(int argc, const char** argv) { ...@@ -775,7 +775,7 @@ int HeadlessShellMain(int argc, const char** argv) {
if (command_line.HasSwitch(switches::kHideScrollbars)) { if (command_line.HasSwitch(switches::kHideScrollbars)) {
builder.SetOverrideWebPreferencesCallback( builder.SetOverrideWebPreferencesCallback(
base::Bind([](WebPreferences* preferences) { base::BindRepeating([](WebPreferences* preferences) {
preferences->hide_scrollbars = true; preferences->hide_scrollbars = true;
})); }));
} }
......
...@@ -658,7 +658,7 @@ IN_PROC_BROWSER_TEST_F(HeadlessBrowserAllowInsecureLocalhostTest, ...@@ -658,7 +658,7 @@ IN_PROC_BROWSER_TEST_F(HeadlessBrowserAllowInsecureLocalhostTest,
class HeadlessBrowserTestAppendCommandLineFlags : public HeadlessBrowserTest { class HeadlessBrowserTestAppendCommandLineFlags : public HeadlessBrowserTest {
public: public:
HeadlessBrowserTestAppendCommandLineFlags() { HeadlessBrowserTestAppendCommandLineFlags() {
options()->append_command_line_flags_callback = base::Bind( options()->append_command_line_flags_callback = base::BindRepeating(
&HeadlessBrowserTestAppendCommandLineFlags::AppendCommandLineFlags, &HeadlessBrowserTestAppendCommandLineFlags::AppendCommandLineFlags,
base::Unretained(this)); base::Unretained(this));
} }
......
...@@ -68,7 +68,8 @@ class HeadlessBrowserContextIsolationTest ...@@ -68,7 +68,8 @@ class HeadlessBrowserContextIsolationTest
void RunDevTooledTest() override { void RunDevTooledTest() override {
load_observer_.reset(new LoadObserver( load_observer_.reset(new LoadObserver(
devtools_client_.get(), devtools_client_.get(),
base::Bind(&HeadlessBrowserContextIsolationTest::OnFirstLoadComplete, base::BindOnce(
&HeadlessBrowserContextIsolationTest::OnFirstLoadComplete,
base::Unretained(this)))); base::Unretained(this))));
devtools_client_->GetPage()->Navigate( devtools_client_->GetPage()->Navigate(
embedded_test_server()->GetURL("/hello.html").spec()); embedded_test_server()->GetURL("/hello.html").spec());
...@@ -78,7 +79,8 @@ class HeadlessBrowserContextIsolationTest ...@@ -78,7 +79,8 @@ class HeadlessBrowserContextIsolationTest
EXPECT_TRUE(load_observer_->navigation_succeeded()); EXPECT_TRUE(load_observer_->navigation_succeeded());
load_observer_.reset(new LoadObserver( load_observer_.reset(new LoadObserver(
devtools_client2_.get(), devtools_client2_.get(),
base::Bind(&HeadlessBrowserContextIsolationTest::OnSecondLoadComplete, base::BindOnce(
&HeadlessBrowserContextIsolationTest::OnSecondLoadComplete,
base::Unretained(this)))); base::Unretained(this))));
devtools_client2_->GetPage()->Navigate( devtools_client2_->GetPage()->Navigate(
embedded_test_server()->GetURL("/hello.html").spec()); embedded_test_server()->GetURL("/hello.html").spec());
...@@ -244,7 +246,7 @@ IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, ContextWebPreferences) { ...@@ -244,7 +246,7 @@ IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, ContextWebPreferences) {
browser() browser()
->CreateBrowserContextBuilder() ->CreateBrowserContextBuilder()
.SetOverrideWebPreferencesCallback( .SetOverrideWebPreferencesCallback(
base::Bind([](WebPreferences* preferences) { base::BindRepeating([](WebPreferences* preferences) {
preferences->hide_scrollbars = true; preferences->hide_scrollbars = true;
})) }))
.Build(); .Build();
......
...@@ -83,7 +83,7 @@ class HeadlessDevToolsClientWindowManagementTest ...@@ -83,7 +83,7 @@ class HeadlessDevToolsClientWindowManagementTest
public: public:
void SetWindowBounds( void SetWindowBounds(
const gfx::Rect& rect, const gfx::Rect& rect,
base::Callback<void(std::unique_ptr<browser::SetWindowBoundsResult>)> base::OnceCallback<void(std::unique_ptr<browser::SetWindowBoundsResult>)>
callback) { callback) {
std::unique_ptr<browser::Bounds> bounds = std::unique_ptr<browser::Bounds> bounds =
browser::Bounds::Builder() browser::Bounds::Builder()
...@@ -100,12 +100,12 @@ class HeadlessDevToolsClientWindowManagementTest ...@@ -100,12 +100,12 @@ class HeadlessDevToolsClientWindowManagementTest
.SetBounds(std::move(bounds)) .SetBounds(std::move(bounds))
.Build(); .Build();
browser_devtools_client_->GetBrowser()->GetExperimental()->SetWindowBounds( browser_devtools_client_->GetBrowser()->GetExperimental()->SetWindowBounds(
std::move(params), callback); std::move(params), std::move(callback));
} }
void SetWindowState( void SetWindowState(
const browser::WindowState state, const browser::WindowState state,
base::Callback<void(std::unique_ptr<browser::SetWindowBoundsResult>)> base::OnceCallback<void(std::unique_ptr<browser::SetWindowBoundsResult>)>
callback) { callback) {
std::unique_ptr<browser::Bounds> bounds = std::unique_ptr<browser::Bounds> bounds =
browser::Bounds::Builder().SetWindowState(state).Build(); browser::Bounds::Builder().SetWindowState(state).Build();
...@@ -116,11 +116,11 @@ class HeadlessDevToolsClientWindowManagementTest ...@@ -116,11 +116,11 @@ class HeadlessDevToolsClientWindowManagementTest
.SetBounds(std::move(bounds)) .SetBounds(std::move(bounds))
.Build(); .Build();
browser_devtools_client_->GetBrowser()->GetExperimental()->SetWindowBounds( browser_devtools_client_->GetBrowser()->GetExperimental()->SetWindowBounds(
std::move(params), callback); std::move(params), std::move(callback));
} }
void GetWindowBounds( void GetWindowBounds(
base::Callback<void(std::unique_ptr<browser::GetWindowBoundsResult>)> base::OnceCallback<void(std::unique_ptr<browser::GetWindowBoundsResult>)>
callback) { callback) {
int window_id = HeadlessWebContentsImpl::From(web_contents_)->window_id(); int window_id = HeadlessWebContentsImpl::From(web_contents_)->window_id();
std::unique_ptr<browser::GetWindowBoundsParams> params = std::unique_ptr<browser::GetWindowBoundsParams> params =
...@@ -129,7 +129,7 @@ class HeadlessDevToolsClientWindowManagementTest ...@@ -129,7 +129,7 @@ class HeadlessDevToolsClientWindowManagementTest
.Build(); .Build();
browser_devtools_client_->GetBrowser()->GetExperimental()->GetWindowBounds( browser_devtools_client_->GetBrowser()->GetExperimental()->GetWindowBounds(
std::move(params), callback); std::move(params), std::move(callback));
} }
void CheckWindowBounds( void CheckWindowBounds(
...@@ -153,14 +153,14 @@ class HeadlessDevToolsClientChangeWindowBoundsTest ...@@ -153,14 +153,14 @@ class HeadlessDevToolsClientChangeWindowBoundsTest
void RunDevTooledTest() override { void RunDevTooledTest() override {
SetWindowBounds( SetWindowBounds(
gfx::Rect(100, 200, 300, 400), gfx::Rect(100, 200, 300, 400),
base::Bind( base::BindOnce(
&HeadlessDevToolsClientChangeWindowBoundsTest::OnSetWindowBounds, &HeadlessDevToolsClientChangeWindowBoundsTest::OnSetWindowBounds,
base::Unretained(this))); base::Unretained(this)));
} }
void OnSetWindowBounds( void OnSetWindowBounds(
std::unique_ptr<browser::SetWindowBoundsResult> result) { std::unique_ptr<browser::SetWindowBoundsResult> result) {
GetWindowBounds(base::Bind( GetWindowBounds(base::BindOnce(
&HeadlessDevToolsClientChangeWindowBoundsTest::OnGetWindowBounds, &HeadlessDevToolsClientChangeWindowBoundsTest::OnGetWindowBounds,
base::Unretained(this))); base::Unretained(this)));
} }
...@@ -185,14 +185,14 @@ class HeadlessDevToolsClientChangeWindowStateTest ...@@ -185,14 +185,14 @@ class HeadlessDevToolsClientChangeWindowStateTest
void RunDevTooledTest() override { void RunDevTooledTest() override {
SetWindowState( SetWindowState(
state_, state_,
base::Bind( base::BindOnce(
&HeadlessDevToolsClientChangeWindowStateTest::OnSetWindowState, &HeadlessDevToolsClientChangeWindowStateTest::OnSetWindowState,
base::Unretained(this))); base::Unretained(this)));
} }
void OnSetWindowState( void OnSetWindowState(
std::unique_ptr<browser::SetWindowBoundsResult> result) { std::unique_ptr<browser::SetWindowBoundsResult> result) {
GetWindowBounds(base::Bind( GetWindowBounds(base::BindOnce(
&HeadlessDevToolsClientChangeWindowStateTest::OnGetWindowState, &HeadlessDevToolsClientChangeWindowStateTest::OnGetWindowState,
base::Unretained(this))); base::Unretained(this)));
} }
......
...@@ -44,7 +44,7 @@ class SynchronousLoadObserver { ...@@ -44,7 +44,7 @@ class SynchronousLoadObserver {
web_contents_->GetDevToolsTarget()->AttachClient(devtools_client_.get()); web_contents_->GetDevToolsTarget()->AttachClient(devtools_client_.get());
load_observer_.reset(new LoadObserver( load_observer_.reset(new LoadObserver(
devtools_client_.get(), devtools_client_.get(),
base::Bind(&HeadlessBrowserTest::FinishAsynchronousTest, base::BindOnce(&HeadlessBrowserTest::FinishAsynchronousTest,
base::Unretained(browser_test)))); base::Unretained(browser_test))));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment