Disable ReportBubblingScrollToSameView DumpWithoutCrashing.

This DumpWithoutCrashing is not providing any further useful information
so we'll disable it for now.

Bug: 828422
Change-Id: I73a62d09b0755375d8b353e620b4627611e8cd7a
Reviewed-on: https://chromium-review.googlesource.com/1000019Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549255}

content/browser/renderer_host/render_widget_host_input_event_router.cc

@@ -21,7 +21,6 @@
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/browser/renderer_host/render_widget_host_view_child_frame.h"
 #include "content/common/frame_messages.h"
-#include "content/public/browser/devtools_agent_host.h"
 #include "services/viz/public/interfaces/hit_test/hit_test_region_list.mojom.h"
 #include "third_party/blink/public/platform/web_input_event.h"
 #include "ui/base/layout.h"
@@ -735,26 +734,12 @@ void RenderWidgetHostInputEventRouter::SendMouseEnterOrLeaveEvents(
 void RenderWidgetHostInputEventRouter::ReportBubblingScrollToSameView(
     const blink::WebGestureEvent& event,
     const RenderWidgetHostViewBase* view) {
-  static auto* type_key = base::debug::AllocateCrashKeyString(
-      "same-view-bubble-event-type", base::debug::CrashKeySize::Size32);
-  base::debug::ScopedCrashKeyString type_key_value(
-      type_key, std::to_string(event.GetType()));
-  static auto* device_key = base::debug::AllocateCrashKeyString(
-      "same-view-bubble-source-device", base::debug::CrashKeySize::Size32);
-  base::debug::ScopedCrashKeyString device_key_value(
-      device_key, std::to_string(event.SourceDevice()));
-
-  // Issue 824772 is a potential cause for issue 818214. Report whether
-  // devtools is in use to investigate whether there are other causes.
-  auto* contents = view->host()->delegate()->GetAsWebContents();
-  const bool have_devtools =
-      contents && DevToolsAgentHost::IsDebuggerAttached(contents);
-  static auto* devtools_key = base::debug::AllocateCrashKeyString(
-      "same-view-bubble-have-devtools", base::debug::CrashKeySize::Size32);
-  base::debug::ScopedCrashKeyString devtools_key_value(
-      devtools_key, std::to_string(have_devtools));
-
+#if 0
+  // For now, we've disabled the DumpWithoutCrashing as it's no longer
+  // providing useful information.
+  // TODO(828422): Determine useful crash keys and reenable the report.
   base::debug::DumpWithoutCrashing();
+#endif
 }
 
 namespace {
@@ -834,7 +819,7 @@ void RenderWidgetHostInputEventRouter::BubbleScrollEvent(
     // We've seen reports of this, but don't know the cause yet. For now,
     // instead of CHECKing or hanging, we'll report the issue and abort scroll
     // bubbling.
-    // TODO(818214): Remove once this issue no longer occurs.
+    // TODO(828422): Remove once this issue no longer occurs.
     if (resending_view == bubbling_gesture_scroll_target_.target) {
       ReportBubblingScrollToSameView(event, resending_view);
       first_bubbling_scroll_target_.target = nullptr;

content/browser/renderer_host/render_widget_host_input_event_router.h

@@ -232,7 +232,7 @@ class CONTENT_EXPORT RenderWidgetHostInputEventRouter
                                         gfx::PointF* transformed_point,
                                         viz::EventSource source) const;
 
-  // TODO(818214): Remove once this issue no longer occurs.
+  // TODO(828422): Remove once this issue no longer occurs.
   void ReportBubblingScrollToSameView(const blink::WebGestureEvent& event,
                                       const RenderWidgetHostViewBase* view);