Commit 406524c9 authored by fmeawad's avatar fmeawad Committed by Commit bot

Enable Speedometer on Android

Speedometer on Android timesout, each iteration takes ~75 seconds on N7.
Limiting the iterations count to 3 on android, and enabling the test.

BUG=382517

Review URL: https://codereview.chromium.org/505903002

Cr-Commit-Position: refs/heads/master@{#291868}
parent 362c3256
...@@ -37,6 +37,12 @@ class SpeedometerMeasurement(page_test.PageTest): ...@@ -37,6 +37,12 @@ class SpeedometerMeasurement(page_test.PageTest):
def ValidateAndMeasurePage(self, page, tab, results): def ValidateAndMeasurePage(self, page, tab, results):
tab.WaitForDocumentReadyStateToBeComplete() tab.WaitForDocumentReadyStateToBeComplete()
iterationCount = 10
# A single iteration on android takes ~75 seconds, the benchmark times out
# when running for 10 iterations.
if tab.browser.platform.GetOSName() == 'android':
iterationCount = 3
tab.ExecuteJavaScript(""" tab.ExecuteJavaScript("""
// Store all the results in the benchmarkClient // Store all the results in the benchmarkClient
benchmarkClient._measuredValues = [] benchmarkClient._measuredValues = []
...@@ -44,9 +50,9 @@ class SpeedometerMeasurement(page_test.PageTest): ...@@ -44,9 +50,9 @@ class SpeedometerMeasurement(page_test.PageTest):
benchmarkClient._measuredValues.push(measuredValues); benchmarkClient._measuredValues.push(measuredValues);
benchmarkClient._timeValues.push(measuredValues.total); benchmarkClient._timeValues.push(measuredValues.total);
}; };
benchmarkClient.iterationCount = 10; benchmarkClient.iterationCount = %d;
startTest(); startTest();
""") """ % iterationCount)
tab.WaitForJavaScriptExpression( tab.WaitForJavaScriptExpression(
'benchmarkClient._finishedTestCount == benchmarkClient.testsCount', 600) 'benchmarkClient._finishedTestCount == benchmarkClient.testsCount', 600)
results.AddValue(list_of_scalar_values.ListOfScalarValues( results.AddValue(list_of_scalar_values.ListOfScalarValues(
...@@ -66,7 +72,6 @@ class SpeedometerMeasurement(page_test.PageTest): ...@@ -66,7 +72,6 @@ class SpeedometerMeasurement(page_test.PageTest):
suite_times; suite_times;
""" % suite_name), important=False)) """ % suite_name), important=False))
@benchmark.Disabled('android') # Times out
class Speedometer(benchmark.Benchmark): class Speedometer(benchmark.Benchmark):
test = SpeedometerMeasurement test = SpeedometerMeasurement
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment