Commit 407d6db9 authored by Peter Wen's avatar Peter Wen Committed by Commit Bot

Android: Add owners for errorprone

Update README for errorprone and add owners. Use a single jar to make
maintenance easier and to pave the way to updates in the future.

BUG=383646

Change-Id: Ib9e2900141baab73515c957bb274b7568ef3102a
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/700856
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506526}
parent cf30efc5
...@@ -286,7 +286,7 @@ deps = { ...@@ -286,7 +286,7 @@ deps = {
}, },
'src/third_party/errorprone/lib': { 'src/third_party/errorprone/lib': {
'url': Var('chromium_git') + '/chromium/third_party/errorprone.git' + '@' + '0eea83b66343133b9c76b7d3288c30321818ebcf', 'url': Var('chromium_git') + '/chromium/third_party/errorprone.git' + '@' + '0f2d079e6ae4be0880bae71952a8b7203767724f',
'condition': 'checkout_android', 'condition': 'checkout_android',
}, },
......
...@@ -4,40 +4,7 @@ ...@@ -4,40 +4,7 @@
import("//build/config/android/rules.gni") import("//build/config/android/rules.gni")
java_prebuilt("error_prone_annotation_java") {
jar_path = "lib/error_prone_annotation-2.0.5.jar"
}
java_prebuilt("error_prone_annotations_java") {
jar_path = "lib/error_prone_annotations-2.0.5.jar"
}
java_prebuilt("javac_java") {
output_name = "javac_java"
jar_path = "lib/javac-1.9.0-dev-r2644-1.jar"
}
java_prebuilt("dataflow_java") {
jar_path = "lib/dataflow-1.8.10.jar"
}
java_prebuilt("javacutil_java") {
jar_path = "lib/javacutil-1.8.10.jar"
}
java_prebuilt("chromium_errorprone") { java_prebuilt("chromium_errorprone") {
jar_path = "lib/error_prone_core-2.0.5.jar" jar_path = "lib/error_prone_ant-2.0.5.jar"
deps = [
":dataflow_java",
":error_prone_annotation_java",
":error_prone_annotations_java",
":javac_java",
":javacutil_java",
"//third_party/findbugs:format_string_java",
]
main_class = "com.google.errorprone.ErrorProneCompiler" main_class = "com.google.errorprone.ErrorProneCompiler"
# TODO(mikecase): Remove this extra arg when the bots are on jdk8 or higher.
bootclasspath =
"$root_build_dir/lib.java/third_party/errorprone/javac_java.jar"
} }
agrieve@chromium.org
jbudorick@chromium.org jbudorick@chromium.org
mikecase@chromium.org wnwen@chromium.org
...@@ -2,15 +2,20 @@ Name: Error Prone ...@@ -2,15 +2,20 @@ Name: Error Prone
Short Name: errorprone Short Name: errorprone
URL: http://errorprone.info/ URL: http://errorprone.info/
Version: 2.0.5 Version: 2.0.5
Date: September 22, 2015 Date: October 4, 2017
License: Apache 2.0 License: Apache 2.0
License File: LICENSE License File: LICENSE
Security Critical: no Security Critical: no
Description: Description:
Catch common Java mistakes as compile-time errors * Catch common Java mistakes as compile-time errors.
* Download a version of error_prone_ant from the maven repository:
* https://repo1.maven.org/maven2/com/google/errorprone/error_prone_ant/
* Add jar file to the lib/ subdirectory, commit, update BUILD.gn and DEPS.
* Remember to ensure that cronet still compiles using the following bots:
* master.tryserver.chromium.android:android_cronet_tester
* master.tryserver.chromium.mac:ios-simulator-cronet
Local Modifications: Local Modifications:
No changes to the original source * No changes to the original source.
Added gn and gyp files * Add BUILD.gn.
Use javac jar from https://github.com/google/error-prone-javac when building.
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment