Commit 40b13290 authored by mef's avatar mef Committed by Commit bot

[Cronet] Change package_ios.py to generate dSYM for debug builds.

Review-Url: https://codereview.chromium.org/2332333005
Cr-Commit-Position: refs/heads/master@{#418877}
parent 7410211a
...@@ -91,15 +91,16 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''): ...@@ -91,15 +91,16 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''):
os.makedirs(out_dir) os.makedirs(out_dir)
build_dir = '' build_dir = ''
for (build_config, gn_extra_args) in [('Debug', 'is_debug=true'), for (build_config, gn_extra_args) in [('Debug', 'is_debug=true'),
('Release', 'is_debug=false enable_dsyms=true enable_stripping=true')]: ('Release', 'is_debug=false enable_stripping=true')]:
for (target_device, target_cpu, additional_cpu) in [('os', 'arm', 'arm64'), for (target_device, target_cpu, additional_cpu) in [('os', 'arm', 'arm64'),
('simulator', 'x86', 'x64')]: ('simulator', 'x86', 'x64')]:
target_dir = '%s-iphone%s' % (build_config, target_device) target_dir = '%s-iphone%s' % (build_config, target_device)
build_dir = os.path.join("out", target_dir) build_dir = os.path.join("out", target_dir)
gn_args = 'target_os="ios" enable_websockets=false ' \ gn_args = 'target_os="ios" enable_websockets=false ' \
'is_cronet_build=true is_component_build=false ' \
'disable_file_support=true disable_ftp_support=true ' \ 'disable_file_support=true disable_ftp_support=true ' \
'use_platform_icu_alternatives=true ' \ 'use_platform_icu_alternatives=true ' \
'disable_brotli_filter=true ' \ 'disable_brotli_filter=true enable_dsyms=true ' \
'target_cpu="%s" additional_target_cpus = ["%s"] %s' % \ 'target_cpu="%s" additional_target_cpus = ["%s"] %s' % \
(target_cpu, additional_cpu, gn_extra_args) (target_cpu, additional_cpu, gn_extra_args)
...@@ -117,8 +118,7 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''): ...@@ -117,8 +118,7 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''):
# Copy framework. # Copy framework.
shutil.copytree(os.path.join(build_dir, 'Cronet.framework'), shutil.copytree(os.path.join(build_dir, 'Cronet.framework'),
os.path.join(out_dir, target_dir, 'Cronet.framework')) os.path.join(out_dir, target_dir, 'Cronet.framework'))
# Copy symbols from release binaries. # Copy symbols.
if 'Release' in build_config:
shutil.copytree(os.path.join(build_dir, 'Cronet.dSYM'), shutil.copytree(os.path.join(build_dir, 'Cronet.dSYM'),
os.path.join(out_dir, target_dir, 'Cronet.framework.dSYM')) os.path.join(out_dir, target_dir, 'Cronet.framework.dSYM'))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment