Commit 40bfe1ee authored by Reid Kleckner's avatar Reid Kleckner Committed by Commit Bot

Revert "Roll clang n332890-c2443155-1 : n333938-3a6da112-1."

This reverts commit 0d406dbc.

Reason for revert:
- Fuchsia arm64 bug (crbug.com/1037700)
- Android arm64 bug (crbug.com/1037912)
- 10% perf regression (crbug.com/1036818)

Original change's description:
> Reland "Roll clang n332890-c2443155-1 : n333938-3a6da112-1."
>
> This is a reland of b21c79dc
>
> Original change's description:
> > Roll clang n332890-c2443155-1 : n333938-3a6da112-1.
> >
> > Ran `./tools/clang/scripts/upload_revision.py 3a6da1122b990386edeba0987d0d1fdc9c8dc53d`.
> >
> > Bug: 1030664
> > Change-Id: I229bf8fd0d65fcacdab5f002220d1350b38aedb6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966387
> > Auto-Submit: Reid Kleckner <rnk@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#727069}
>
> Bug: 1030664
> Change-Id: I7a7fdcf7b0c6bd22f4840748318f7180931ea468
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979068
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#727096}

TBR=thakis@chromium.org,ukai@chromium.org,hans@chromium.org,rnk@chromium.org

Bug: 1030664, 1037700, 1037912, 1036818
Change-Id: If73d19f7f5a0febdd83087b0a6f257f8ad21a36f
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982227
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: default avatarReid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727515}
parent 9dc85663
...@@ -632,15 +632,6 @@ config("compiler") { ...@@ -632,15 +632,6 @@ config("compiler") {
"-Wl,--thinlto-cache-policy,$cache_policy", "-Wl,--thinlto-cache-policy,$cache_policy",
] ]
} }
# Disable TypePromotion to work around compiler crash in Android LTO builds.
# TODO(crbug.com/1033863): Fixed upstream; remove in next clang roll.
if (!llvm_force_head_revision && target_os != "chromeos") {
ldflags += [
"-Wl,-mllvm",
"-Wl,-disable-type-promotion=true",
]
}
} else { } else {
ldflags += [ "-Wl,-plugin-opt,jobs=" + max_jobs_per_link ] ldflags += [ "-Wl,-plugin-opt,jobs=" + max_jobs_per_link ]
} }
...@@ -1537,9 +1528,6 @@ config("default_warnings") { ...@@ -1537,9 +1528,6 @@ config("default_warnings") {
# TODO(https://crbug.com/1028110): Evaluate and possible enable. # TODO(https://crbug.com/1028110): Evaluate and possible enable.
"-Wno-deprecated-copy", "-Wno-deprecated-copy",
# TODO(https://crbug.com/1031169): Clean up and enable.
"-Wno-misleading-indentation",
] ]
if (is_win) { if (is_win) {
...@@ -1553,6 +1541,13 @@ config("default_warnings") { ...@@ -1553,6 +1541,13 @@ config("default_warnings") {
# TODO(https://crbug.com/995993): Clean up and enable. # TODO(https://crbug.com/995993): Clean up and enable.
"-Wno-implicit-fallthrough", "-Wno-implicit-fallthrough",
] ]
if (llvm_force_head_revision) {
cflags += [
# TODO(https://crbug.com/1031169): Clean up and enable.
"-Wno-misleading-indentation",
]
}
} }
} }
} }
......
...@@ -39,8 +39,8 @@ import zipfile ...@@ -39,8 +39,8 @@ import zipfile
# Do NOT CHANGE this if you don't know what you're doing -- see # Do NOT CHANGE this if you don't know what you're doing -- see
# https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang.md # https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang.md
# Reverting problematic clang rolls is safe, though. # Reverting problematic clang rolls is safe, though.
CLANG_REVISION = '3a6da1122b990386edeba0987d0d1fdc9c8dc53d' CLANG_REVISION = 'c2443155a0fb245c8f17f2c1c72b6ea391e86e81'
CLANG_SVN_REVISION = 'n333938' CLANG_SVN_REVISION = 'n332890'
CLANG_SUB_REVISION = 1 CLANG_SUB_REVISION = 1
PACKAGE_VERSION = '%s-%s-%s' % (CLANG_SVN_REVISION, CLANG_REVISION[:8], PACKAGE_VERSION = '%s-%s-%s' % (CLANG_SVN_REVISION, CLANG_REVISION[:8],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment