Commit 41f9647f authored by calamity's avatar calamity Committed by Commit Bot

Revert "DevTools: allow showing views above and below the Sources sidebar."

This reverts commit d21d2ed3.

Reason for revert: Causing devtools_eslint failure
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928389307771200912/+/steps/devtools_eslint/0/stdout

Original change's description:
> DevTools: allow showing views above and below the Sources sidebar.
> 
> Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817
> Reviewed-on: https://chromium-review.googlesource.com/c/1357513
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612830}

TBR=dgozman@chromium.org,pfeldman@chromium.org,kozy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I58fd8fab81766fee2aca0747a78f4ac61647f7cf
Reviewed-on: https://chromium-review.googlesource.com/c/1358118Reviewed-by: default avatarcalamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613013}
parent c9af3f14
......@@ -2,7 +2,7 @@
"extensions": [
{
"type": "view",
"location": "sources.sidebar-bottom",
"location": "sources-sidebar",
"id": "sources.eventListenerBreakpoints",
"title": "Event Listener Breakpoints",
"order": 9,
......@@ -18,7 +18,7 @@
},
{
"type": "view",
"location": "sources.sidebar-bottom",
"location": "sources-sidebar",
"id": "sources.xhrBreakpoints",
"title": "XHR/fetch Breakpoints",
"order": 5,
......@@ -28,7 +28,7 @@
},
{
"type": "view",
"location": "sources.sidebar-bottom",
"location": "sources-sidebar",
"id": "sources.domBreakpoints",
"title": "DOM Breakpoints",
"order": 7,
......@@ -67,7 +67,7 @@
},
{
"type": "view",
"location": "sources.sidebar-bottom",
"location": "sources-sidebar",
"id": "sources.globalListeners",
"title": "Global Listeners",
"order": 8,
......
......@@ -251,13 +251,11 @@ Sources.SourcesPanel = class extends UI.Panel {
* @return {?UI.ViewLocation}
*/
resolveLocation(locationName) {
if (locationName === 'sources.sidebar-top' || locationName === 'sources.sidebar-bottom' ||
locationName === 'sources.sidebar-tabs') {
if (locationName === 'sources-sidebar')
return this._sidebarPaneStack;
} else {
else
return this._navigatorTabbedLocation;
}
}
/**
* @return {boolean}
......@@ -901,7 +899,6 @@ Sources.SourcesPanel = class extends UI.Panel {
this._sidebarPaneStack.widget().element.classList.add('overflow-auto');
this._sidebarPaneStack.widget().show(vbox.element);
this._sidebarPaneStack.widget().element.appendChild(this._debuggerPausedMessage.element());
this._sidebarPaneStack.appendApplicableItems('sources.sidebar-top');
vbox.element.appendChild(this._debugToolbar.element);
if (this._threadsSidebarPane)
......@@ -940,12 +937,11 @@ Sources.SourcesPanel = class extends UI.Panel {
this._splitWidget.installResizer(this._debugToolbar.gripElementForResize());
tabbedLocation.appendView(scopeChainView);
tabbedLocation.appendView(this._watchSidebarPane);
tabbedLocation.appendApplicableItems('sources.sidebar-tabs');
this._extensionSidebarPanesContainer = tabbedLocation;
this.sidebarPaneView = splitWidget;
}
this._sidebarPaneStack.appendApplicableItems('sources.sidebar-bottom');
this._sidebarPaneStack.appendApplicableItems('sources-sidebar');
const extensionSidebarPanes = Extensions.extensionServer.sidebarPanes();
for (let i = 0; i < extensionSidebarPanes.length; ++i)
this._addExtensionSidebarPane(extensionSidebarPanes[i]);
......
......@@ -715,24 +715,11 @@
{
"type": "@UI.ViewLocationResolver",
"name": "navigator-view",
"category": "Sources",
"className": "Sources.SourcesPanel"
},
{
"type": "@UI.ViewLocationResolver",
"name": "sources.sidebar-top",
"category": "Sources",
"className": "Sources.SourcesPanel"
},
{
"type": "@UI.ViewLocationResolver",
"name": "sources.sidebar-bottom",
"category": "Sources",
"className": "Sources.SourcesPanel"
},
{
"type": "@UI.ViewLocationResolver",
"name": "sources.sidebar-tabs",
"name": "sources-sidebar",
"category": "Sources",
"className": "Sources.SourcesPanel"
},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment