[Nickname Management] Clean up nickname management in settings UI

Clean up nicknameManagementEnabled flag and remove the legacy elements and
CSS config.

Local build test video after clean up(googlers only):
https://drive.google.com/file/d/1uYmVuIjlThiGl-TTeGvPrZWvDtkBJwKJ/view?usp=sharing&resourcekey=0-hMW3nVLEyQ7fbLzV5RHwqg

Bug: 1082013
Change-Id: Ie5ba1372cf510decb17a113c67ed5aee11eeb755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600180
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#839145}

chrome/browser/resources/settings/autofill_page/credit_card_edit_dialog.html

     <style include="cr-shared-style settings-shared md-select">
       cr-input {
-        --cr-input-error-display: none;
-        margin-bottom: var(--cr-form-field-bottom-spacing);
-        width: var(--settings-input-max-width);
-      }
-
-      /* Larger cr-input margin (by reserving space for error display) when
-      nickname management is enabled. */
-      :host([nickname-management-enabled_]) cr-input {
+        /* Larger cr-input margin (by reserving space for error display). */
         --cr-input-error-display: block;
         margin-bottom: 0;
+        width: var(--settings-input-max-width);
       }
 
-      /* Override the padding-top (the space is set by save-to-this-device) when
-      nickname management is enabled. */
-      :host([nickname-management-enabled_]) div[slot='button-container'] {
+      /* Override the padding-top (the space is set by save-to-this-device). */
+      div[slot='button-container'] {
         padding-top: 0;
       }
 
@@ -22,33 +15,11 @@
         margin-inline-start: 8px;
       }
 
-      #expired {
-        align-items: center;
-        background-color: var(--paper-red-50);
-        color: var(--settings-error-color);
-        display: flex;
-        height: 40px;
-        margin-top: 12px;
-        padding: 0 0 0 8px;
-      }
-
-      @media (prefers-color-scheme: dark) {
-        #expired {
-          background-color: unset;
-          font-weight: bold;
-          padding: 0;
-        }
-      }
-
       #month {
         width: 70px;
       }
 
       #saved-to-this-device-only-label {
-        margin-top: var(--cr-form-field-bottom-spacing);
-      }
-
-      :host([nickname-management-enabled_]) #saved-to-this-device-only-label {
         /* Overall space between input fields, including space between
            nicknameInput and saved-to-this-device text, between
            saved-to-this-device text and button. */
@@ -91,13 +62,13 @@
       }
 
       #expired-error,
-      :host([nickname-management-enabled_][expired_]) #expiration {
+      :host([expired_]) #expiration {
         color: var(--google-red-600);
       }
 
       @media (prefers-color-scheme: dark) {
         #expired-error,
-        :host([nickname-management-enabled_][expired_]) #expiration {
+        :host([expired_]) #expiration {
           color: var(--google-red-refresh-300);
         }
       }
@@ -105,12 +76,6 @@
     <cr-dialog id="dialog" close-text="$i18n{close}">
       <div slot="title">[[title_]]</div>
       <div slot="body">
-        <!-- Place and autofocus the cardholder name as the first field when
-          nickname management is not enabled. -->
-        <cr-input id="legacyNameInput" label="$i18n{creditCardName}"
-            value="{{creditCard.name}}" spellcheck="false"
-            hidden$="[[nicknameManagementEnabled_]]" autofocus>
-        </cr-input>
         <cr-input id="numberInput" label="$i18n{creditCardNumber}"
             value="{{creditCard.cardNumber}}" autofocus>
         </cr-input>
@@ -136,20 +101,8 @@
             <option>[[item]]</option>
           </template>
         </select>
-        <!-- Use new error message text under the drop down when nickname
-          management is enabled.-->
-        <div id="expired-error" hidden="[[!nicknameManagementEnabled_]]">
-          $i18n{creditCardExpired}
-        </div>
-        <!-- Reuse current error message span when nickname management is
-          disabled.-->
-        <span id="expired" hidden="[[!showLegacyExpiredError_(expired_,
-            nicknameManagementEnabled_)]]">
-          $i18n{creditCardExpired}
-        </span>
-        <!-- Place cardholder name field and nickname field after expiration
-          when nickname management is enabled.-->
-        <template is="dom-if" if="[[nicknameManagementEnabled_]]">
+        <div id="expired-error">$i18n{creditCardExpired}</div>
+        <!-- Place cardholder name field and nickname field after expiration.-->
         <cr-input id="nameInput" label="$i18n{creditCardName}"
             value="{{creditCard.name}}" spellcheck="false">
         </cr-input>
@@ -162,7 +115,6 @@
               [[computeNicknameCharCount_(creditCard.nickname)]]/25
             </div>
         </cr-input>
-        </template>
         <div id="saved-to-this-device-only-label">
           $i18n{savedToThisDeviceOnly}
         </div>

chrome/browser/resources/settings/autofill_page/credit_card_edit_dialog.js

@@ -70,18 +70,6 @@ Polymer({
     /** @private {string|undefined} */
     expirationMonth_: String,
 
-    /**
-     * True if nickname management is enabled.
-     * @private
-     */
-    nicknameManagementEnabled_: {
-      type: Boolean,
-      reflectToAttribute: true,
-      value() {
-        return loadTimeData.getBoolean('nicknameManagementEnabled');
-      }
-    },
-
     /**
      * Whether the current nickname input is invalid.
      * @private
@@ -211,24 +199,12 @@ Polymer({
         !this.expired_ && !this.nicknameInvalid_;
   },
 
-  /**
-   * @return {boolean} True iff the card is expired and nickname management is
-   *     disabled.
-   * @private
-   */
-  // TODO(crbug.com/1082013): Remove legacy expired error message when nickname
-  // management is fully enabled.
-  showLegacyExpiredError_() {
-    return !this.nicknameManagementEnabled_ && this.expired_;
-  },
-
   /**
    * Handles a11y error announcement the same way as in cr-input.
    * @private
    */
   onExpiredChanged_() {
-    const ERROR_ID =
-        this.nicknameManagementEnabled_ ? 'expired-error' : 'expired';
+    const ERROR_ID = 'expired-error';
     const errorElement = this.$$(`#${ERROR_ID}`);
     // Readding attributes is needed for consistent announcement by VoiceOver
     if (this.expired_) {

chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc

@@ -1118,10 +1118,6 @@ void AddAutofillStrings(content::WebUIDataSource* html_source,
                           base::FeatureList::IsEnabled(
                               autofill::features::kAutofillSaveAndFillVPA));
 
-  html_source->AddBoolean(
-      "nicknameManagementEnabled",
-      base::FeatureList::IsEnabled(
-          autofill::features::kAutofillEnableCardNicknameManagement));
   AddLocalizedStringsBulk(html_source, kLocalizedStrings);
 }
 

chrome/test/data/webui/settings/payments_section_interactive_test.js

@@ -105,28 +105,7 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
     return (new Date().getFullYear() - 1).toString();
   }
 
-  test('add card dialog when nickname management disabled', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: false});
-    const creditCardDialog = createAddCreditCardDialog();
-
-    // Wait for the dialog to open.
-    await whenAttributeIs(creditCardDialog.$$('#dialog'), 'open', '');
-
-    // Verify the nickname input field is not shown when nickname management is
-    // disabled.
-    assertFalse(!!creditCardDialog.$$('#nicknameInput'));
-    assertFalse(!!creditCardDialog.$$('#nameInput'));
-    // Legacy cardholder name input field is not hidden.
-    assertFalse(creditCardDialog.$$('#legacyNameInput').hidden);
-
-    // Verify the legacy cardholder name field is autofocused when nickname
-    // management is enabled.
-    assertTrue(
-        creditCardDialog.$$('#legacyNameInput').matches(':focus-within'));
-  });
-
-  test('add card dialog when nickname management is enabled', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
+  test('add card dialog', async function() {
     const creditCardDialog = createAddCreditCardDialog();
 
     // Wait for the dialog to open.
@@ -136,46 +115,13 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
     // enabled.
     assertTrue(!!creditCardDialog.$$('#nicknameInput'));
     assertTrue(!!creditCardDialog.$$('#nameInput'));
-    // Legacy cardholder name input field is hidden.
-    assertTrue(creditCardDialog.$$('#legacyNameInput').hidden);
 
     // Verify the card number field is autofocused when nickname management is
     // enabled.
     assertTrue(creditCardDialog.$$('#numberInput').matches(':focus-within'));
   });
 
-  test('save new card when nickname management is disabled', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: false});
-    const creditCardDialog = createAddCreditCardDialog();
-
-    // Wait for the dialog to open.
-    await whenAttributeIs(creditCardDialog.$$('#dialog'), 'open', '');
-
-    // Fill in name to the legacy name input field and card number.
-    creditCardDialog.$$('#legacyNameInput').value = 'Jane Doe';
-    creditCardDialog.$$('#numberInput').value = '4111111111111111';
-    // Select next year as the expiration year.
-    creditCardDialog.$.year.value = nextYear();
-    creditCardDialog.$.year.dispatchEvent(new CustomEvent('change'));
-    flush();
-
-    assertTrue(creditCardDialog.$.expired.hidden);
-    assertFalse(creditCardDialog.$.saveButton.disabled);
-
-    const savedPromise = eventToPromise('save-credit-card', creditCardDialog);
-    creditCardDialog.$.saveButton.click();
-    const saveEvent = await savedPromise;
-
-    // Verify the input values are correctly passed to save-credit-card.
-    // guid is empty when saving a new card.
-    assertEquals(saveEvent.detail.guid, undefined);
-    assertEquals(saveEvent.detail.name, 'Jane Doe');
-    assertEquals(saveEvent.detail.cardNumber, '4111111111111111');
-    assertEquals(saveEvent.detail.expirationYear, nextYear());
-  });
-
-  test('save new card when nickname management is enabled', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
+  test('save new card', async function() {
     const creditCardDialog = createAddCreditCardDialog();
 
     // Wait for the dialog to open.
@@ -190,7 +136,8 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
     creditCardDialog.$.year.dispatchEvent(new CustomEvent('change'));
     flush();
 
-    assertTrue(creditCardDialog.$.expired.hidden);
+    const expiredError = creditCardDialog.$$('#expired-error');
+    assertEquals('hidden', getComputedStyle(expiredError).visibility);
     assertFalse(creditCardDialog.$.saveButton.disabled);
 
     const savedPromise = eventToPromise('save-credit-card', creditCardDialog);
@@ -207,7 +154,6 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
   });
 
   test('trim credit card when save', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
     const creditCardDialog = createAddCreditCardDialog();
 
     // Wait for the dialog to open.
@@ -222,7 +168,8 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
     creditCardDialog.$.year.dispatchEvent(new CustomEvent('change'));
     flush();
 
-    assertTrue(creditCardDialog.$.expired.hidden);
+    const expiredError = creditCardDialog.$$('#expired-error');
+    assertEquals('hidden', getComputedStyle(expiredError).visibility);
     assertFalse(creditCardDialog.$.saveButton.disabled);
 
     const savedPromise = eventToPromise('save-credit-card', creditCardDialog);
@@ -239,7 +186,6 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
   });
 
   test('update local card value', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
     const creditCard = createCreditCardEntry();
     creditCard.name = 'Wrong name';
     creditCard.nickname = 'Shopping Card';
@@ -257,7 +203,8 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
     assertEquals(creditCardDialog.$$('#numberInput').value, '4444333322221111');
     assertEquals(creditCardDialog.$.year.value, nextYear());
 
-    assertTrue(creditCardDialog.$.expired.hidden);
+    const expiredError = creditCardDialog.$$('#expired-error');
+    assertEquals('hidden', getComputedStyle(expiredError).visibility);
     assertFalse(creditCardDialog.$.saveButton.disabled);
 
     // Update cardholder name, card number, expiration year and nickname, and
@@ -282,7 +229,6 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
   });
 
   test('show error message when input nickname is invalid', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
     const creditCardDialog = createAddCreditCardDialog();
 
     // Wait for the dialog to open.
@@ -326,7 +272,6 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
   });
 
   test('disable save button when input nickname is invalid', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
     const creditCard = createCreditCardEntry();
     creditCard.name = 'Wrong name';
     // Set the expiration year to next year to avoid expired card.
@@ -351,7 +296,6 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
   });
 
   test('only show nickname character count when focused', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
     const creditCardDialog = createAddCreditCardDialog();
 
     // Wait for the dialog to open.
@@ -390,49 +334,7 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
     assertTrue(characterCount.textContent.includes('5/25'));
   });
 
-  test('expired card when nickname management is disabled', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: false});
-    const creditCard = createCreditCardEntry();
-    // Set the expiration year to the previous year to simulate expired card.
-    creditCard.expirationYear = lastYear();
-    // Edit dialog for an existing card with no nickname.
-    const creditCardDialog = createEditCreditCardDialog([creditCard]);
-
-    // Wait for the dialog to open.
-    await whenAttributeIs(creditCardDialog.$$('#dialog'), 'open', '');
-
-    // Verify save button is disabled for expired credit card.
-    assertTrue(creditCardDialog.$.saveButton.disabled);
-    // Legacy expired error message is shown, the new error message is still
-    // hidden.
-    assertFalse(creditCardDialog.$.expired.hidden);
-    assertTrue(creditCardDialog.$$('#expired-error').hidden);
-    // Check a11y attributes added for correct error announcement.
-    assertEquals('alert', creditCardDialog.$.expired.getAttribute('role'));
-    for (const select of [creditCardDialog.$.month, creditCardDialog.$.year]) {
-      assertEquals('true', select.getAttribute('aria-invalid'));
-      assertEquals('expired', select.getAttribute('aria-errormessage'));
-    }
-
-    // Update the expiration year to next year to avoid expired card.
-    creditCardDialog.$.year.value = nextYear();
-    creditCardDialog.$.year.dispatchEvent(new CustomEvent('change'));
-    flush();
-
-    // Expired error message is hidden for valid expiration date.
-    assertTrue(creditCardDialog.$.expired.hidden);
-    assertTrue(creditCardDialog.$$('#expired-error').hidden);
-    assertFalse(creditCardDialog.$.saveButton.disabled);
-    // Check a11y attributes for expiration error removed.
-    assertEquals(null, creditCardDialog.$.expired.getAttribute('role'));
-    for (const select of [creditCardDialog.$.month, creditCardDialog.$.year]) {
-      assertEquals('false', select.getAttribute('aria-invalid'));
-      assertEquals(null, select.getAttribute('aria-errormessage'));
-    }
-  });
-
-  test('expired card when nickname management is enabled', async function() {
-    loadTimeData.overrideValues({nicknameManagementEnabled: true});
+  test('expired card', async function() {
     const creditCard = createCreditCardEntry();
     // Set the expiration year to the previous year to simulate expired card.
     creditCard.expirationYear = lastYear();
@@ -445,10 +347,8 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
     // Verify save button is disabled for expired credit card.
     assertTrue(creditCardDialog.$.saveButton.disabled);
     const expiredError = creditCardDialog.$$('#expired-error');
-    // The new expired error message is shown, the legacy error message is still
-    // hidden.
+    // The expired error message is shown.
     assertEquals('visible', getComputedStyle(expiredError).visibility);
-    assertTrue(creditCardDialog.$.expired.hidden);
     // Check a11y attributes added for correct error announcement.
     assertEquals('alert', expiredError.getAttribute('role'));
     for (const select of [creditCardDialog.$.month, creditCardDialog.$.year]) {
@@ -463,7 +363,6 @@ suite('PaymentsSectionCreditCardEditDialogTest', function() {
 
     // Expired error message is hidden for valid expiration date.
     assertEquals('hidden', getComputedStyle(expiredError).visibility);
-    assertTrue(creditCardDialog.$.expired.hidden);
     assertFalse(creditCardDialog.$.saveButton.disabled);
     // Check a11y attributes for expiration error removed.
     assertEquals(null, expiredError.getAttribute('role'));

chrome/test/data/webui/settings/payments_section_test.js

@@ -309,14 +309,15 @@ suite('PaymentsSection', function() {
         .then(function() {
           // Not expired, but still can't be saved, because there's no
           // name.
-          assertTrue(creditCardDialog.$.expired.hidden);
+          const expiredError = creditCardDialog.$$('#expired-error');
+          assertEquals('hidden', getComputedStyle(expiredError).visibility);
           assertTrue(creditCardDialog.$.saveButton.disabled);
 
           // Add a name.
           creditCardDialog.set('creditCard.name', 'Jane Doe');
           flush();
 
-          assertTrue(creditCardDialog.$.expired.hidden);
+          assertEquals('hidden', getComputedStyle(expiredError).visibility);
           assertFalse(creditCardDialog.$.saveButton.disabled);
 
           const savedPromise =