Commit 42710d41 authored by Ryan Hansberry's avatar Ryan Hansberry Committed by Commit Bot

[Tether] Log response code of unsuccessful TetherAvailabilityResponse.

This will help to more easily identify why users cannot find their
Tether hosts when they provide feedback reports.

Change-Id: Iff6d51f7e27eef36ed0312ba5c6ef61979ee8634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900246
Auto-Submit: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712779}
parent 67c6d71e
...@@ -199,7 +199,7 @@ void HostScannerOperation::OnMessageReceived( ...@@ -199,7 +199,7 @@ void HostScannerOperation::OnMessageReceived(
static_cast<TetherAvailabilityResponse*>( static_cast<TetherAvailabilityResponse*>(
message_wrapper->GetProto().get()); message_wrapper->GetProto().get());
if (AreGmsCoreNotificationsDisabled(response)) { if (AreGmsCoreNotificationsDisabled(response)) {
PA_LOG(VERBOSE) PA_LOG(WARNING)
<< "Received TetherAvailabilityResponse from device with ID " << "Received TetherAvailabilityResponse from device with ID "
<< remote_device.GetTruncatedDeviceIdForLogs() << " which " << remote_device.GetTruncatedDeviceIdForLogs() << " which "
<< "indicates that Google Play Services notifications are " << "indicates that Google Play Services notifications are "
...@@ -209,10 +209,11 @@ void HostScannerOperation::OnMessageReceived( ...@@ -209,10 +209,11 @@ void HostScannerOperation::OnMessageReceived(
} else if (!IsTetheringAvailableWithValidDeviceStatus(response)) { } else if (!IsTetheringAvailableWithValidDeviceStatus(response)) {
// If the received message is invalid or if it states that tethering is // If the received message is invalid or if it states that tethering is
// unavailable, ignore it. // unavailable, ignore it.
PA_LOG(VERBOSE) PA_LOG(WARNING)
<< "Received TetherAvailabilityResponse from device with ID " << "Received TetherAvailabilityResponse from device with ID "
<< remote_device.GetTruncatedDeviceIdForLogs() << " which " << remote_device.GetTruncatedDeviceIdForLogs() << " which "
<< "indicates that tethering is not available."; << "indicates that tethering is not available. Response code: "
<< response->response_code();
} else { } else {
bool setup_required = bool setup_required =
response->response_code() == response->response_code() ==
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment