Revert "Use V8GeneratedCoreBindings only in jumbo build"
This reverts commit 6bdfe3b9. Reason for revert: Broke official win asan build crbug.com/797202 FAILED: obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False lib.exe /nologo /ignore:4221 /OUT:obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib @obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib.rsp LINK : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib : fatal error LNK1248: image size (1001D34E4) exceeds maximum allowable size (FFFFFFFF) Original change's description: > Use V8GeneratedCoreBindings only in jumbo build > > This is retry of > https://codereview.chromium.org/2318933002/ > > Current chromium/src can build all with is_official_build=true in windows. > This improves build parallelism on windows. > > Bug: 634231 > Change-Id: Ie16541b56d90718ab01a992b7f4cbc07caebcd22 > Reviewed-on: https://chromium-review.googlesource.com/836627 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525565} TBR=peria@chromium.org,bashi@chromium.org,haraken@chromium.org,tikuta@google.com,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 634231, 797202 Change-Id: I86c3a554a5121ab94c7950a97de7b9914b0a7b95 Reviewed-on: https://chromium-review.googlesource.com/842564 Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#525966}
Showing
Please register or sign in to comment