Commit 44d57965 authored by Sadrul Habib Chowdhury's avatar Sadrul Habib Chowdhury Committed by Commit Bot

[cc/metrics] Include more information in traces.

Two changes to PipelineReporter traces:
 . Set |state| correctly for partial updates.
 . For dropped (or partially dropped) frames, report whether
   the frame affects smoothness or not.

BUG=1125152

Change-Id: If282c20bc19931b14b3f71c589e9fa78e25e4710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410618
Commit-Queue: Xida Chen <xidachen@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806757}
parent f9525952
...@@ -849,12 +849,19 @@ void CompositorFrameReporter::ReportCompositorLatencyTraceEvents() const { ...@@ -849,12 +849,19 @@ void CompositorFrameReporter::ReportCompositorLatencyTraceEvents() const {
FrameTerminationStatus::kDidNotProduceFrame) { FrameTerminationStatus::kDidNotProduceFrame) {
state = ChromeFrameReporter::STATE_NO_UPDATE_DESIRED; state = ChromeFrameReporter::STATE_NO_UPDATE_DESIRED;
} else { } else {
state = ChromeFrameReporter::STATE_PRESENTED_ALL; state = has_partial_update()
? ChromeFrameReporter::STATE_PRESENTED_PARTIAL
: ChromeFrameReporter::STATE_PRESENTED_ALL;
} }
auto* reporter = context.event()->set_chrome_frame_reporter(); auto* reporter = context.event()->set_chrome_frame_reporter();
reporter->set_state(state); reporter->set_state(state);
reporter->set_frame_source(args_.frame_id.source_id); reporter->set_frame_source(args_.frame_id.source_id);
reporter->set_frame_sequence(args_.frame_id.sequence_number); reporter->set_frame_sequence(args_.frame_id.sequence_number);
if (IsDroppedFrameAffectingSmoothness()) {
DCHECK(state == ChromeFrameReporter::STATE_DROPPED ||
state == ChromeFrameReporter::STATE_PRESENTED_PARTIAL);
reporter->set_affects_smoothness(true);
}
// TODO(crbug.com/1086974): Set 'drop reason' if applicable. // TODO(crbug.com/1086974): Set 'drop reason' if applicable.
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment