Commit 4526ff71 authored by Robbie Gibson's avatar Robbie Gibson Committed by Commit Bot

[iOS] Prevent DCHECK when closing Find In Page/Text Zoom

The reason the DCHECK was being hit is because this forwarder wasn't
being properly cleaned up.

Fixed: 1044606
Change-Id: Iae58f7af86a6bc0af57a6f93756c0954fba43413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013132
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734066}
parent 2f7e99f9
...@@ -43,6 +43,10 @@ ...@@ -43,6 +43,10 @@
return self; return self;
} }
- (void)dealloc {
_forwarder = nullptr;
}
#pragma mark - CRWWebStateObserver #pragma mark - CRWWebStateObserver
- (void)webState:(web::WebState*)webState - (void)webState:(web::WebState*)webState
......
...@@ -68,6 +68,8 @@ ...@@ -68,6 +68,8 @@
_webStateList->RemoveObserver(_webStateListObserver.get()); _webStateList->RemoveObserver(_webStateListObserver.get());
_webStateListObserver = nullptr; _webStateListObserver = nullptr;
_webStateList = nullptr; _webStateList = nullptr;
_forwarder = nullptr;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment