Commit 45ff10d9 authored by Charlene Yan's avatar Charlene Yan Committed by Commit Bot

[Tab Groups] Add about://flags entry for automatic tab group creation.

Bug: 1128703
Change-Id: I2769ea96b8982fdb3b777eebc97b558217fa7ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413109
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807320}
parent a4571d9f
...@@ -4119,6 +4119,10 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -4119,6 +4119,10 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kTabGroupsDescription, kOsDesktop, flag_descriptions::kTabGroupsDescription, kOsDesktop,
FEATURE_VALUE_TYPE(features::kTabGroups)}, FEATURE_VALUE_TYPE(features::kTabGroups)},
{"tab-groups-auto-create", flag_descriptions::kTabGroupsAutoCreateName,
flag_descriptions::kTabGroupsAutoCreateDescription, kOsDesktop,
FEATURE_VALUE_TYPE(features::kTabGroupsAutoCreate)},
{"tab-groups-collapse", flag_descriptions::kTabGroupsCollapseName, {"tab-groups-collapse", flag_descriptions::kTabGroupsCollapseName,
flag_descriptions::kTabGroupsCollapseDescription, kOsDesktop, flag_descriptions::kTabGroupsCollapseDescription, kOsDesktop,
FEATURE_VALUE_TYPE(features::kTabGroupsCollapse)}, FEATURE_VALUE_TYPE(features::kTabGroupsCollapse)},
......
...@@ -4343,6 +4343,11 @@ ...@@ -4343,6 +4343,11 @@
"owners": [ "chrome-desktop-ui-seattle@google.com", "connily" ], "owners": [ "chrome-desktop-ui-seattle@google.com", "connily" ],
"expiry_milestone": 88 "expiry_milestone": 88
}, },
{
"name": "tab-groups-auto-create",
"owners": [ "chrome-desktop-ui-seattle@google.com", "xialinyan" ],
"expiry_milestone": 89
},
{ {
"name": "tab-groups-collapse", "name": "tab-groups-collapse",
"owners": [ "chrome-desktop-ui-seattle@google.com", "xialinyan" ], "owners": [ "chrome-desktop-ui-seattle@google.com", "xialinyan" ],
......
...@@ -2311,6 +2311,10 @@ const char kTabGroupsDescription[] = ...@@ -2311,6 +2311,10 @@ const char kTabGroupsDescription[] =
"Allows users to organize tabs into visually distinct groups, e.g. to " "Allows users to organize tabs into visually distinct groups, e.g. to "
"separate tabs associated with different tasks."; "separate tabs associated with different tasks.";
const char kTabGroupsAutoCreateName[] = "Tab Groups Auto Create";
const char kTabGroupsAutoCreateDescription[] =
"Automatically creates groups for users, if tab groups are enabled.";
const char kTabGroupsCollapseName[] = "Tab Groups Collapse"; const char kTabGroupsCollapseName[] = "Tab Groups Collapse";
const char kTabGroupsCollapseDescription[] = const char kTabGroupsCollapseDescription[] =
"Allows a tab group to be collapsible and expandable, if tab groups are " "Allows a tab group to be collapsible and expandable, if tab groups are "
......
...@@ -1326,6 +1326,9 @@ extern const char kTabToGTSAnimationAndroidDescription[]; ...@@ -1326,6 +1326,9 @@ extern const char kTabToGTSAnimationAndroidDescription[];
extern const char kTabGroupsName[]; extern const char kTabGroupsName[];
extern const char kTabGroupsDescription[]; extern const char kTabGroupsDescription[];
extern const char kTabGroupsAutoCreateName[];
extern const char kTabGroupsAutoCreateDescription[];
extern const char kTabGroupsCollapseName[]; extern const char kTabGroupsCollapseName[];
extern const char kTabGroupsCollapseDescription[]; extern const char kTabGroupsCollapseDescription[];
......
...@@ -63,6 +63,11 @@ const base::Feature kSignInProfileCreationFlow{ ...@@ -63,6 +63,11 @@ const base::Feature kSignInProfileCreationFlow{
// Enables grouping tabs together in the tab strip. https://crbug.com/905491 // Enables grouping tabs together in the tab strip. https://crbug.com/905491
const base::Feature kTabGroups{"TabGroups", base::FEATURE_ENABLED_BY_DEFAULT}; const base::Feature kTabGroups{"TabGroups", base::FEATURE_ENABLED_BY_DEFAULT};
// Automatically create groups for users based on domain.
// https://crbug.com/1128703
const base::Feature kTabGroupsAutoCreate{"TabGroupsAutoCreate",
base::FEATURE_DISABLED_BY_DEFAULT};
// Enables tab groups to be collapsed and expanded. https://crbug.com/1018230 // Enables tab groups to be collapsed and expanded. https://crbug.com/1018230
const base::Feature kTabGroupsCollapse{"TabGroupsCollapse", const base::Feature kTabGroupsCollapse{"TabGroupsCollapse",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
......
...@@ -44,6 +44,8 @@ extern const base::Feature kSignInProfileCreationFlow; ...@@ -44,6 +44,8 @@ extern const base::Feature kSignInProfileCreationFlow;
extern const base::Feature kTabGroups; extern const base::Feature kTabGroups;
extern const base::Feature kTabGroupsAutoCreate;
extern const base::Feature kTabGroupsCollapse; extern const base::Feature kTabGroupsCollapse;
extern const base::Feature kTabGroupsCollapseFreezing; extern const base::Feature kTabGroupsCollapseFreezing;
......
...@@ -40599,6 +40599,7 @@ from previous Chrome versions. ...@@ -40599,6 +40599,7 @@ from previous Chrome versions.
<int value="-2017953534" label="enable-hosted-app-shim-creation"/> <int value="-2017953534" label="enable-hosted-app-shim-creation"/>
<int value="-2017778637" label="PrintSaveToDrive:disabled"/> <int value="-2017778637" label="PrintSaveToDrive:disabled"/>
<int value="-2015293660" label="AccessibilityExposeDisplayNone:disabled"/> <int value="-2015293660" label="AccessibilityExposeDisplayNone:disabled"/>
<int value="-2014948560" label="TabGroupsAutoCreate:enabled"/>
<int value="-2013551096" label="ViewsSimplifiedFullscreenUI:disabled"/> <int value="-2013551096" label="ViewsSimplifiedFullscreenUI:disabled"/>
<int value="-2013124655" label="EnableEphemeralFlashPermission:disabled"/> <int value="-2013124655" label="EnableEphemeralFlashPermission:disabled"/>
<int value="-2012990889" label="SpannableInlineAutocomplete:enabled"/> <int value="-2012990889" label="SpannableInlineAutocomplete:enabled"/>
...@@ -41828,6 +41829,7 @@ from previous Chrome versions. ...@@ -41828,6 +41829,7 @@ from previous Chrome versions.
<int value="-820041355" label="enable-transition-compositing"/> <int value="-820041355" label="enable-transition-compositing"/>
<int value="-816984237" label="OfflinePagesAsyncDownload:enabled"/> <int value="-816984237" label="OfflinePagesAsyncDownload:enabled"/>
<int value="-816895294" label="DiscoverApp:disabled"/> <int value="-816895294" label="DiscoverApp:disabled"/>
<int value="-816404462" label="TabGroupsAutoCreate:disabled"/>
<int value="-815213125" label="SplitSettings:enabled"/> <int value="-815213125" label="SplitSettings:enabled"/>
<int value="-814097014" label="disable-session-crashed-bubble"/> <int value="-814097014" label="disable-session-crashed-bubble"/>
<int value="-813753274" label="VrBrowsing:disabled"/> <int value="-813753274" label="VrBrowsing:disabled"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment