Commit 461849ad authored by Theresa Sullivan's avatar Theresa Sullivan Committed by Chromium LUCI CQ

Restrict TabbedAppMenuTest#testBookmarkMenuItem to phones

The bookmark star is only shown in the app menu on phones; on tablets it
is shown in the toolbar instead.

Bug: 1169415
Change-Id: I52c267501eb2d67474ba8fbe2cdacc573fd83940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643936
Auto-Submit: Theresa  <twellington@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: default avatarGang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845990}
parent 2a947a01
...@@ -29,7 +29,6 @@ import org.chromium.base.test.util.CallbackHelper; ...@@ -29,7 +29,6 @@ import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Criteria; import org.chromium.base.test.util.Criteria;
import org.chromium.base.test.util.CriteriaHelper; import org.chromium.base.test.util.CriteriaHelper;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest; import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
...@@ -55,7 +54,6 @@ import org.chromium.content_public.browser.test.util.TestThreadUtils; ...@@ -55,7 +54,6 @@ import org.chromium.content_public.browser.test.util.TestThreadUtils;
import org.chromium.content_public.browser.test.util.TestTouchUtils; import org.chromium.content_public.browser.test.util.TestTouchUtils;
import org.chromium.ui.modaldialog.ModalDialogProperties; import org.chromium.ui.modaldialog.ModalDialogProperties;
import org.chromium.ui.modelutil.PropertyModel; import org.chromium.ui.modelutil.PropertyModel;
import org.chromium.ui.test.util.UiDisableIf;
import org.chromium.ui.test.util.UiRestriction; import org.chromium.ui.test.util.UiRestriction;
import java.io.IOException; import java.io.IOException;
...@@ -250,7 +248,7 @@ public class TabbedAppMenuTest { ...@@ -250,7 +248,7 @@ public class TabbedAppMenuTest {
@Feature({"Browser", "Main", "Bookmark", "RenderTest"}) @Feature({"Browser", "Main", "Bookmark", "RenderTest"})
@DisableFeatures({ChromeFeatureList.TABBED_APP_OVERFLOW_MENU_REGROUP, @DisableFeatures({ChromeFeatureList.TABBED_APP_OVERFLOW_MENU_REGROUP,
ChromeFeatureList.TABBED_APP_OVERFLOW_MENU_ICONS}) ChromeFeatureList.TABBED_APP_OVERFLOW_MENU_ICONS})
@DisableIf.Device(type = {UiDisableIf.TABLET}) // See https://crbug.com/1065043. @Restriction(UiRestriction.RESTRICTION_TYPE_PHONE)
public void public void
testBookmarkMenuItem() throws IOException { testBookmarkMenuItem() throws IOException {
MenuItem bookmarkStar = MenuItem bookmarkStar =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment