Dismisses SaveCard Infobar on Navigation in iOS

- Adds is_form_navigation member to the NavigationDetails struct. This
struct is sent to the InfobarDelegate after each Navigation.
- Dismisses the SaveCard Infobar unless the navigation was triggered
by a form submission or is a redirect.
- Creates kAutofillSaveCardDismissOnNavigation feature flag for the new
behaviour.

Bug: 1021412
Change-Id: I6cf5973a635586a8f21d65a50bb750a4ea0c4070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890734
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712853}

components/autofill/core/browser/payments/autofill_save_card_infobar_delegate_mobile.cc

@@ -10,6 +10,7 @@
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "build/branding_buildflags.h"
+#include "build/build_config.h"
 #include "components/autofill/core/browser/autofill_experiments.h"
 #include "components/autofill/core/browser/data_model/credit_card.h"
 #include "components/autofill/core/common/autofill_constants.h"
@@ -118,10 +119,22 @@ AutofillSaveCardInfoBarDelegateMobile::GetIdentifier() const {
 
 bool AutofillSaveCardInfoBarDelegateMobile::ShouldExpire(
     const NavigationDetails& details) const {
+#if defined(OS_IOS)
+  if (base::FeatureList::IsEnabled(
+          features::kAutofillSaveCardDismissOnNavigation)) {
+    // Expire the Infobar unless the navigation was triggered by the form that
+    // presented the Infobar, or the navigation is a redirect.
+    return !details.is_form_submission && !details.is_redirect;
+  } else {
+    // Use the default behavior used by Android.
+    return false;
+  }
+#else   // defined(OS_IOS)
   // The user has submitted a form, causing the page to navigate elsewhere. We
   // don't want the infobar to be expired at this point, because the user won't
   // get a chance to answer the question.
   return false;
+#endif  // defined(OS_IOS)
 }
 
 void AutofillSaveCardInfoBarDelegateMobile::InfoBarDismissed() {

components/autofill/core/common/autofill_payments_features.cc

@@ -67,6 +67,11 @@ const base::Feature kAutofillNoLocalSaveOnUnmaskSuccess{
 const base::Feature kAutofillNoLocalSaveOnUploadSuccess{
     "AutofillNoLocalSaveOnUploadSuccess", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// When enabled, the Save Card infobar will be dismissed by a user initiated
+// navigation other than one caused by submitted form.
+const base::Feature kAutofillSaveCardDismissOnNavigation{
+    "AutofillSaveCardDismissOnNavigation", base::FEATURE_ENABLED_BY_DEFAULT};
+
 // Controls whether to show updated UI for the card unmask prompt.
 const base::Feature kAutofillUpdatedCardUnmaskPromptUi{
     "AutofillUpdatedCardUnmaskPromptUi", base::FEATURE_DISABLED_BY_DEFAULT};

components/autofill/core/common/autofill_payments_features.h

@@ -28,6 +28,7 @@ extern const base::Feature kAutofillEnableLocalCardMigrationForNonSyncUser;
 extern const base::Feature kAutofillEnableToolbarStatusChip;
 extern const base::Feature kAutofillNoLocalSaveOnUnmaskSuccess;
 extern const base::Feature kAutofillNoLocalSaveOnUploadSuccess;
+extern const base::Feature kAutofillSaveCardDismissOnNavigation;
 extern const base::Feature kAutofillUpdatedCardUnmaskPromptUi;
 extern const base::Feature kAutofillUpstream;
 extern const base::Feature kAutofillUpstreamAllowAllEmailDomains;

components/infobars/core/infobar_delegate.h

@@ -172,6 +172,8 @@ class InfoBarDelegate {
     bool did_replace_entry;
     bool is_reload;
     bool is_redirect;
+    // True if the navigation was caused by a form submission.
+    bool is_form_submission = false;
   };
 
   // Value to use when the InfoBar has no icon to show.

ios/chrome/browser/flags/about_flags.mm

@@ -556,6 +556,12 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
     {"use-WKWebView-loading", flag_descriptions::kUseWKWebViewLoadingName,
      flag_descriptions::kUseWKWebViewLoadingDescription, flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(web::features::kUseWKWebViewLoading)},
+    {"autofill-save-card-dismiss-on-navigation",
+     flag_descriptions::kAutofillSaveCardDismissOnNavigationName,
+     flag_descriptions::kAutofillSaveCardDismissOnNavigationDescription,
+     flags_ui::kOsIos,
+     FEATURE_VALUE_TYPE(
+         autofill::features::kAutofillSaveCardDismissOnNavigation)},
 };
 
 // Add all switches from experimental flags to |command_line|.

ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc

@@ -74,6 +74,12 @@ const char kAutofillPruneSuggestionsName[] = "Autofill Prune Suggestions";
 const char kAutofillPruneSuggestionsDescription[] =
     "Further limits the number of suggestions in the Autofill dropdown.";
 
+const char kAutofillSaveCardDismissOnNavigationName[] =
+    "Save Card Dismiss on Navigation";
+const char kAutofillSaveCardDismissOnNavigationDescription[] =
+    "Dismisses the Save Card Infobar on a user initiated Navigation, other "
+    "than one caused by submitted form.";
+
 const char kAutofillShowAllSuggestionsOnPrefilledFormsName[] =
     "Enable showing all suggestions when focusing prefilled field";
 const char kAutofillShowAllSuggestionsOnPrefilledFormsDescription[] =

ios/chrome/browser/flags/ios_chrome_flag_descriptions.h

@@ -52,6 +52,11 @@ extern const char kAutofillNoLocalSaveOnUploadSuccessDescription[];
 extern const char kAutofillPruneSuggestionsName[];
 extern const char kAutofillPruneSuggestionsDescription[];
 
+// Title and description for the flag to control dismissing the Save Card
+// Infobar on Navigation.
+extern const char kAutofillSaveCardDismissOnNavigationName[];
+extern const char kAutofillSaveCardDismissOnNavigationDescription[];
+
 // Title and description for the flag to control if prefilled value filter
 // profiles.
 extern const char kAutofillShowAllSuggestionsOnPrefilledFormsName[];

ios/chrome/browser/infobars/infobar_manager_impl.mm

@@ -33,7 +33,8 @@ infobars::InfoBarDelegate::NavigationDetails CreateNavigationDetails(
   navigation_details.is_reload =
       ui::PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_RELOAD);
   navigation_details.is_redirect = ui::PageTransitionIsRedirect(transition);
-
+  navigation_details.is_form_submission =
+      ui::PageTransitionCoreTypeIs(transition, ui::PAGE_TRANSITION_FORM_SUBMIT);
   return navigation_details;
 }