Revert of Remove use of deprecated MessageLoop methods in ipc. (patchset #1...
Revert of Remove use of deprecated MessageLoop methods in ipc. (patchset #1 id:1 of https://codereview.chromium.org/2037853002/ ) Reason for revert: MessageLoopForIO::current() has a DCHECK but ThreadTaskRunnerHandle::Get() doesn't. See discussion https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Wj_cNO2l2qE Original issue's description: > Remove use of deprecated MessageLoop methods in ipc. > > MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon > are deprecated. This CL makes the following replacements to > remove some uses of these methods: > > "MessageLoop(ForUI|ForIO)::current()->PostTask" -> > "ThreadTaskRunnerHandle::Get()->PostTask" > "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" -> > "ThreadTaskRunnerHandle::Get()->PostDelayedTask" > "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" -> > "ThreadTaskRunnerHandle::Get()->DeleteSoon" > "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" -> > "ThreadTaskRunnerHandle::Get()->ReleaseSoon" > > In files where these replacements are made, it adds these includes: > #include "base/location.h" > #include "base/single_thread_task_runner.h" > #include "base/threading/thread_task_runner_handle.h" > > And removes this include if it is no longer required: > #include "base/message_loop/message_loop.h" > > Why ThreadTaskRunnerHandle::Get() instead of > MessageLoop::current()->task_runner()? > - The two are equivalent on threads that run a MessageLoop. > - MessageLoop::current() doesn't work in base/task_scheduler > because the scheduler's thread don't run MessageLoops. > This CL will therefore facilitate the migration of browser > threads to base/task_scheduler. > > Steps to generate this patch: > 1. Run message_loop_cleanup.py (see code on the bug). > 2. Run tools/sort-headers.py on modified files. > 3. Run git cl format. > > BUG=616447 > R=cpu@chromium.org > > Committed: https://crrev.com/2eb9714a01e03a8b091a8ea34f023e24f62e5a9f > Cr-Commit-Position: refs/heads/master@{#398040} TBR=cpu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616447 Review-Url: https://codereview.chromium.org/2038363004 Cr-Commit-Position: refs/heads/master@{#398140}
Showing
Please register or sign in to comment