Port InspectorApplicationCacheAgent to InspectorAgentState.

Bug: 851762
Change-Id: I0208bb9a528c0e40cdb2b962461ac90225cb31b1
Reviewed-on: https://chromium-review.googlesource.com/1164062
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581073}

third_party/blink/renderer/core/inspector/inspector_application_cache_agent.cc

@@ -35,36 +35,32 @@
 #include "third_party/blink/renderer/platform/wtf/text/string_builder.h"
 
 namespace blink {
-
 using protocol::Response;
 
-namespace ApplicationCacheAgentState {
-static const char kApplicationCacheAgentEnabled[] =
-    "applicationCacheAgentEnabled";
-}
-
 InspectorApplicationCacheAgent::InspectorApplicationCacheAgent(
     InspectedFrames* inspected_frames)
-    : inspected_frames_(inspected_frames) {}
+    : inspected_frames_(inspected_frames),
+      enabled_(&agent_state_, /*default_value=*/false) {}
+
+void InspectorApplicationCacheAgent::InnerEnable() {
+  enabled_.Set(true);
+  instrumenting_agents_->addInspectorApplicationCacheAgent(this);
+  GetFrontend()->networkStateUpdated(GetNetworkStateNotifier().OnLine());
+}
 
 void InspectorApplicationCacheAgent::Restore() {
-  if (state_->booleanProperty(
-          ApplicationCacheAgentState::kApplicationCacheAgentEnabled, false)) {
-    enable();
-  }
+  if (enabled_.Get())
+    InnerEnable();
 }
 
 Response InspectorApplicationCacheAgent::enable() {
-  state_->setBoolean(ApplicationCacheAgentState::kApplicationCacheAgentEnabled,
-                     true);
-  instrumenting_agents_->addInspectorApplicationCacheAgent(this);
-  GetFrontend()->networkStateUpdated(GetNetworkStateNotifier().OnLine());
+  if (!enabled_.Get())
+    InnerEnable();
   return Response::OK();
 }
 
 Response InspectorApplicationCacheAgent::disable() {
-  state_->setBoolean(ApplicationCacheAgentState::kApplicationCacheAgentEnabled,
-                     false);
+  enabled_.Clear();
   instrumenting_agents_->removeInspectorApplicationCacheAgent(this);
   return Response::OK();
 }

third_party/blink/renderer/core/inspector/inspector_application_cache_agent.h

@@ -68,6 +68,9 @@ class CORE_EXPORT InspectorApplicationCacheAgent final
       std::unique_ptr<protocol::ApplicationCache::ApplicationCache>*) override;
 
  private:
+  // Unconditionally enables the agent, even if |enabled_.Get()==true|.
+  // For idempotence, call enable().
+  void InnerEnable();
   explicit InspectorApplicationCacheAgent(InspectedFrames*);
 
   std::unique_ptr<protocol::ApplicationCache::ApplicationCache>
@@ -85,6 +88,7 @@ class CORE_EXPORT InspectorApplicationCacheAgent final
                                                    DocumentLoader*&);
 
   Member<InspectedFrames> inspected_frames_;
+  InspectorAgentState::Boolean enabled_;
   DISALLOW_COPY_AND_ASSIGN(InspectorApplicationCacheAgent);
 };