Quota: Hide storage pressure trigger on Android.

Currently, quota internals exposes a button that is used to test the
storage pressure notification, which is not yet available on Android.
This change hides that section on quota internals to prevent users
from crashing the browser when testing this unavailable feature.

Bug: 1076794
Change-Id: I1b25cb52856be9cb419185b74b8bfd89e50f5f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207772
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773977}

chrome/browser/resources/quota_internals/event_handler.js

@@ -390,6 +390,22 @@ function handleStatistics(event) {
   }
 }
 
+/**
+ * Event Handler for |cr.quota.onStoragePressureFlagUpdated|.
+ * |event.detail| contains a boolean representing whether or not to show
+ * the storage pressure UI.
+ * @param {!CustomEvent<!Object>} event StoragePressureFlagUpdated event.
+ */
+function handleStoragePressureFlagInfo(event) {
+  const data = event.detail;
+  $('storage-pressure-loading').hidden = true;
+  if (data.isStoragePressureEnabled) {
+    $('storage-pressure-outer').hidden = false;
+  } else {
+    $('storage-pressure-disabled').hidden = false;
+  }
+}
+
 /**
  * Update description on 'tree-item-description' field with
  * selected item in tree view.
@@ -490,6 +506,8 @@ function onLoad() {
   cr.quota.onPerOriginInfoUpdated.addEventListener(
       'update', handlePerOriginInfo);
   cr.quota.onStatisticsUpdated.addEventListener('update', handleStatistics);
+  cr.quota.onStoragePressureFlagUpdated.addEventListener(
+      'update', handleStoragePressureFlagInfo);
   cr.quota.requestInfo();
 
   $('refresh-button').addEventListener('click', cr.quota.requestInfo, false);

chrome/browser/resources/quota_internals/main.html

@@ -56,7 +56,12 @@ found in the LICENSE file.
       <table>
         <tbody id="stat-entries" class="entries"></tbody>
       </table>
+      <div id="storage-pressure-section">
         <h2>Test Storage Pressure Behavior</h2>
+        <div id="storage-pressure-loading">
+          Loading...
+        </div>
+        <div id="storage-pressure-outer" hidden>
           <div class="pressure">
             Origin to test:
             <input id="storage-pressure-origin"
@@ -67,6 +72,11 @@ found in the LICENSE file.
               Trigger Storage Pressure Notification
             </button>
           </div>
+        </div>
+        <div id="storage-pressure-disabled" hidden>
+          Storage Pressure feature disabled.
+        </div>
+      </div>
     </tabpanel>
 
     <tabpanel>

chrome/browser/resources/quota_internals/message_dispatcher.js

@@ -38,13 +38,15 @@ cr.define('cr.quota', function() {
    *   * onGlobalInfoUpdated,
    *   * onPerHostInfoUpdated,
    *   * onPerOriginInfoUpdated,
-   *   * onStatisticsUpdated.
+   *   * onStatisticsUpdated,
+   *   * onStoragePressureFlagUpdated.
    * @param {string} message Message label. Possible Values are:
    *   * 'AvailableSpaceUpdated',
    *   * 'GlobalInfoUpdated',
    *   * 'PerHostInfoUpdated',
    *   * 'PerOriginInfoUpdated',
-   *   * 'StatisticsUpdated'.
+   *   * 'StatisticsUpdated',
+   *   * 'StoragePressureFlagUpdated'.
    * @param {Object} detail Message specific additional data.
    */
   function messageHandler(message, detail) {
@@ -65,6 +67,9 @@ cr.define('cr.quota', function() {
       case 'StatisticsUpdated':
         target = cr.quota.onStatisticsUpdated;
         break;
+      case 'StoragePressureFlagUpdated':
+        target = cr.quota.onStoragePressureFlagUpdated;
+        break;
       default:
         console.error('Unknown Message');
         break;
@@ -82,6 +87,7 @@ cr.define('cr.quota', function() {
     onPerHostInfoUpdated: new cr.EventTarget(),
     onPerOriginInfoUpdated: new cr.EventTarget(),
     onStatisticsUpdated: new cr.EventTarget(),
+    onStoragePressureFlagUpdated: new cr.EventTarget(),
 
     requestInfo: requestInfo,
     triggerStoragePressure: triggerStoragePressure,

chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc

@@ -7,16 +7,30 @@
 #include <string>
 
 #include "base/bind.h"
-#include "base/bind_helpers.h"
+#include "base/feature_list.h"
 #include "base/values.h"
+#include "build/build_config.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/quota_internals/quota_internals_proxy.h"
 #include "chrome/browser/ui/webui/quota_internals/quota_internals_types.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_ui.h"
+#include "content/public/common/content_features.h"
 
 using content::BrowserContext;
 
+namespace {
+
+bool IsStoragePressureEnabled() {
+#if defined(OS_ANDROID)
+  return false;
+#else
+  return base::FeatureList::IsEnabled(features::kStoragePressureUI);
+#endif
+}
+
+}  // namespace
+
 namespace quota_internals {
 
 QuotaInternalsHandler::QuotaInternalsHandler() {}
@@ -75,6 +89,13 @@ void QuotaInternalsHandler::ReportStatistics(const Statistics& stats) {
   SendMessage("StatisticsUpdated", dict);
 }
 
+void QuotaInternalsHandler::ReportStoragePressureFlag() {
+  base::DictionaryValue flag_enabled;
+  flag_enabled.SetBoolean("isStoragePressureEnabled",
+                          IsStoragePressureEnabled());
+  SendMessage("StoragePressureFlagUpdated", flag_enabled);
+}
+
 void QuotaInternalsHandler::SendMessage(const std::string& message,
                                         const base::Value& value) {
   web_ui()->CallJavascriptFunctionUnsafe("cr.quota.messageHandler",
@@ -84,6 +105,7 @@ void QuotaInternalsHandler::SendMessage(const std::string& message,
 void QuotaInternalsHandler::OnRequestInfo(const base::ListValue*) {
   if (!proxy_.get())
     proxy_ = new QuotaInternalsProxy(this);
+  ReportStoragePressureFlag();
   proxy_->RequestInfo(
       BrowserContext::GetDefaultStoragePartition(
           Profile::FromWebUI(web_ui()))->GetQuotaManager());

chrome/browser/ui/webui/quota_internals/quota_internals_handler.h

@@ -42,6 +42,7 @@ class QuotaInternalsHandler : public content::WebUIMessageHandler {
   void ReportPerHostInfo(const std::vector<PerHostStorageInfo>& hosts);
   void ReportPerOriginInfo(const std::vector<PerOriginStorageInfo>& origins);
   void ReportStatistics(const Statistics& stats);
+  void ReportStoragePressureFlag();
 
  private:
   void OnRequestInfo(const base::ListValue*);