Commit 47d5c006 authored by Jonathon Kereliuk's avatar Jonathon Kereliuk Committed by Commit Bot

[Chromedriver] Disable ScrollTopLeftInterop feature

and enable previously failing tests

Should fix: 
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1852
for python tests, but not java tests

Bug: chromedriver:1852
Change-Id: Iebe5ec09bff943ab54200590c9943713c899f05f
Reviewed-on: https://chromium-review.googlesource.com/594653
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491781}
parent dccc49f0
...@@ -168,8 +168,6 @@ _ANDROID_NEGATIVE_FILTER['chromium'] = ( ...@@ -168,8 +168,6 @@ _ANDROID_NEGATIVE_FILTER['chromium'] = (
'ChromeDriverTest.testHoverOverElement', 'ChromeDriverTest.testHoverOverElement',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1478 # https://bugs.chromium.org/p/chromedriver/issues/detail?id=1478
'ChromeDriverTest.testShouldHandleNewWindowLoadingProperly', 'ChromeDriverTest.testShouldHandleNewWindowLoadingProperly',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1852
'ChromeDriverTest.testTouchScrollElement',
] ]
) )
_ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = ( _ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = (
...@@ -1259,8 +1257,8 @@ class ChromeDriverTest(ChromeDriverBaseTestWithWebServer): ...@@ -1259,8 +1257,8 @@ class ChromeDriverTest(ChromeDriverBaseTestWithWebServer):
def testTouchScrollElement(self): def testTouchScrollElement(self):
self._driver.Load(self.GetHttpUrlForFile( self._driver.Load(self.GetHttpUrlForFile(
'/chromedriver/touch_action_tests.html')) '/chromedriver/touch_action_tests.html'))
scroll_left = 'return document.body.scrollLeft;' scroll_left = 'return document.documentElement.scrollLeft;'
scroll_top = 'return document.body.scrollTop;' scroll_top = 'return document.documentElement.scrollTop;'
self.assertEquals(0, self._driver.ExecuteScript(scroll_left)) self.assertEquals(0, self._driver.ExecuteScript(scroll_left))
self.assertEquals(0, self._driver.ExecuteScript(scroll_top)) self.assertEquals(0, self._driver.ExecuteScript(scroll_top))
target = self._driver.FindElement('id', 'target') target = self._driver.FindElement('id', 'target')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment