Commit 47e48682 authored by treib's avatar treib Committed by Commit bot

Add NewTabPage.MostVisited and .SuggestionsImpression on Android

The same histograms already exist on desktop, see ntp_user_data_logger.cc

BUG=625153

Review-Url: https://codereview.chromium.org/2126263002
Cr-Commit-Position: refs/heads/master@{#405142}
parent 5889b01b
...@@ -253,6 +253,9 @@ void MostVisitedSites::RecordOpenedMostVisitedItem(int index, int tile_type) { ...@@ -253,6 +253,9 @@ void MostVisitedSites::RecordOpenedMostVisitedItem(int index, int tile_type) {
// function to work with asynchronous UI. // function to work with asynchronous UI.
DCHECK_GE(index, 0); DCHECK_GE(index, 0);
DCHECK_LT(index, static_cast<int>(current_suggestions_.size())); DCHECK_LT(index, static_cast<int>(current_suggestions_.size()));
UMA_HISTOGRAM_ENUMERATION("NewTabPage.MostVisited", index, num_sites_);
std::string histogram = base::StringPrintf( std::string histogram = base::StringPrintf(
"NewTabPage.MostVisited.%s", "NewTabPage.MostVisited.%s",
GetSourceHistogramName(current_suggestions_[index].source).c_str()); GetSourceHistogramName(current_suggestions_[index].source).c_str());
...@@ -502,8 +505,6 @@ void MostVisitedSites::NotifyMostVisitedURLsObserver() { ...@@ -502,8 +505,6 @@ void MostVisitedSites::NotifyMostVisitedURLsObserver() {
if (received_most_visited_sites_ && received_popular_sites_ && if (received_most_visited_sites_ && received_popular_sites_ &&
!recorded_uma_) { !recorded_uma_) {
RecordImpressionUMAMetrics(); RecordImpressionUMAMetrics();
UMA_HISTOGRAM_SPARSE_SLOWLY("NewTabPage.NumberOfTiles",
current_suggestions_.size());
recorded_uma_ = true; recorded_uma_ = true;
} }
...@@ -530,7 +531,13 @@ void MostVisitedSites::OnPopularSitesAvailable(bool success) { ...@@ -530,7 +531,13 @@ void MostVisitedSites::OnPopularSitesAvailable(bool success) {
} }
void MostVisitedSites::RecordImpressionUMAMetrics() { void MostVisitedSites::RecordImpressionUMAMetrics() {
UMA_HISTOGRAM_SPARSE_SLOWLY("NewTabPage.NumberOfTiles",
current_suggestions_.size());
for (size_t i = 0; i < current_suggestions_.size(); i++) { for (size_t i = 0; i < current_suggestions_.size(); i++) {
UMA_HISTOGRAM_ENUMERATION(
"NewTabPage.SuggestionsImpression", static_cast<int>(i), num_sites_);
std::string histogram = base::StringPrintf( std::string histogram = base::StringPrintf(
"NewTabPage.SuggestionsImpression.%s", "NewTabPage.SuggestionsImpression.%s",
GetSourceHistogramName(current_suggestions_[i].source).c_str()); GetSourceHistogramName(current_suggestions_[i].source).c_str());
......
...@@ -229,9 +229,6 @@ class MostVisitedSites : public history::TopSitesObserver, ...@@ -229,9 +229,6 @@ class MostVisitedSites : public history::TopSitesObserver,
void OnPopularSitesAvailable(bool success); void OnPopularSitesAvailable(bool success);
// Records thumbnail-related UMA histogram metrics.
void RecordThumbnailUMAMetrics();
// Records UMA histogram metrics related to the number of impressions. // Records UMA histogram metrics related to the number of impressions.
void RecordImpressionUMAMetrics(); void RecordImpressionUMAMetrics();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment