Commit 483cf732 authored by Olivier Li's avatar Olivier Li Committed by Commit Bot

Prevent ScopedTempDir cleanup issues in ProfileSigninConfirmationHelperTest

Bug: 546640
Change-Id: I524066ce81a422938eca2c80523b60c4f9f670c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929094Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717695}
parent 4e87004c
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "base/bind_helpers.h" #include "base/bind_helpers.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/stl_util.h" #include "base/stl_util.h"
...@@ -131,8 +132,11 @@ class ProfileSigninConfirmationHelperTest : public testing::Test { ...@@ -131,8 +132,11 @@ class ProfileSigninConfirmationHelperTest : public testing::Test {
} }
void SetUp() override { void SetUp() override {
ASSERT_TRUE(profile_dir_.CreateUniqueTempDir());
// Create the profile. // Create the profile.
TestingProfile::Builder builder; TestingProfile::Builder builder;
builder.SetPath(profile_dir_.GetPath());
user_prefs_ = new TestingPrefStoreWithCustomReadError; user_prefs_ = new TestingPrefStoreWithCustomReadError;
sync_preferences::TestingPrefServiceSyncable* pref_service = sync_preferences::TestingPrefServiceSyncable* pref_service =
new sync_preferences::TestingPrefServiceSyncable( new sync_preferences::TestingPrefServiceSyncable(
...@@ -168,6 +172,7 @@ class ProfileSigninConfirmationHelperTest : public testing::Test { ...@@ -168,6 +172,7 @@ class ProfileSigninConfirmationHelperTest : public testing::Test {
} }
protected: protected:
base::ScopedTempDir profile_dir_;
content::BrowserTaskEnvironment task_environment_; content::BrowserTaskEnvironment task_environment_;
std::unique_ptr<TestingProfile> profile_; std::unique_ptr<TestingProfile> profile_;
TestingPrefStoreWithCustomReadError* user_prefs_; TestingPrefStoreWithCustomReadError* user_prefs_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment