Commit 48ad4ab5 authored by Francois Doray's avatar Francois Doray Committed by Commit Bot

[sheriff] Disable AutofillProviderBrowserTestWithSkipFlag* tests on all platforms.

TBR=battre@chromium.org

Bug: 1076487
Change-Id: Ic2671b38d51dbd694f4603f2a1d779567084e854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432365Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810773}
parent 3d7c5053
...@@ -309,43 +309,28 @@ class AutofillProviderBrowserTestWithSkipFlagOff ...@@ -309,43 +309,28 @@ class AutofillProviderBrowserTestWithSkipFlagOff
base::test::ScopedFeatureList feature_list_; base::test::ScopedFeatureList feature_list_;
}; };
#if defined(OS_MAC) // TODO(crbug.com/1076487): These tests are flaky on all platforms.
// These tests are flaky on Mac: https://crbug.com/1076487
#define MAYBE_InferredLabelChangeImpactFormComparing \
DISABLED_InferredLabelChangeImpactFormComparing
#define MAYBE_InferredLabelChangeNotImpactFormComparing \
DISABLED_InferredLabelChangeNotImpactFormComparing
#define MAYBE_LabelTagChangeImpactFormComparing \
DISABLED_LabelTagChangeImpactFormComparing
#else
#define MAYBE_InferredLabelChangeImpactFormComparing \
InferredLabelChangeImpactFormComparing
#define MAYBE_InferredLabelChangeNotImpactFormComparing \
InferredLabelChangeNotImpactFormComparing
#define MAYBE_LabelTagChangeImpactFormComparing \
LabelTagChangeImpactFormComparing
#endif
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOn, IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOn,
MAYBE_LabelTagChangeImpactFormComparing) { DISABLED_LabelTagChangeImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery(); SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("label_id", false /*expect_forms_same*/); ChangeLabelAndCheckResult("label_id", false /*expect_forms_same*/);
} }
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOn, IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOn,
MAYBE_InferredLabelChangeNotImpactFormComparing) { DISABLED_InferredLabelChangeNotImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery(); SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("p_id", true /*expect_forms_same*/); ChangeLabelAndCheckResult("p_id", true /*expect_forms_same*/);
} }
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOff, IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOff,
MAYBE_LabelTagChangeImpactFormComparing) { DISABLED_LabelTagChangeImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery(); SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("label_id", false /*expect_forms_same*/); ChangeLabelAndCheckResult("label_id", false /*expect_forms_same*/);
} }
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOff, IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOff,
MAYBE_InferredLabelChangeImpactFormComparing) { DISABLED_InferredLabelChangeImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery(); SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("p_id", false /*expect_forms_same*/); ChangeLabelAndCheckResult("p_id", false /*expect_forms_same*/);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment