DevTools: populate scopes with local variables when on a breakpoint. This...

DevTools: populate scopes with local variables when on a breakpoint. This feature was broken by one of the recent WebKit rolls.
Review URL: http://codereview.chromium.org/202021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25732 0039d316-1c4b-4281-b951-d872f2087c98

webkit/glue/devtools/js/devtools.js

@@ -362,14 +362,31 @@ WebInspector.UIString = function(string) {
 })();
 
 
+(function () {
+var orig = InjectedScriptAccess.getProperties;
+InjectedScriptAccess.getProperties = function(
+    objectProxy, ignoreHasOwnProperty, callback) {
+  if (objectProxy.isScope) {
+    devtools.tools.getDebuggerAgent().resolveScope(objectProxy.objectId,
+        callback);
+  } else if (objectProxy.isV8Ref) {
+    devtools.tools.getDebuggerAgent().resolveChildren(objectProxy.objectId,
+        callback, true);
+  } else {
+    orig.apply(this, arguments);
+  }
+};
+})()
+
+
 WebInspector.resourceTrackingWasEnabled = function()
 {
     InspectorController.resourceTrackingEnabled_ = true;
     this.panels.resources.resourceTrackingWasEnabled();
-}
+};
 
 WebInspector.resourceTrackingWasDisabled = function()
 {
     InspectorController.resourceTrackingEnabled_ = false;
     this.panels.resources.resourceTrackingWasDisabled();
-}
+};

webkit/glue/devtools/js/inspector_controller_impl.js

@@ -234,24 +234,6 @@ devtools.InspectorControllerImpl.prototype.evaluateInCallFrame =
 };
 
 
-/**
- * @override
- */
-devtools.InspectorControllerImpl.prototype.getProperties = function(
-    objectProxy, ignoreHasOwnProperty, callback) {
-  if (objectProxy.isScope) {
-    devtools.tools.getDebuggerAgent().resolveScope(objectProxy.objectId,
-        callback);
-  } else if (objectProxy.isV8Ref) {
-    devtools.tools.getDebuggerAgent().resolveChildren(objectProxy.objectId,
-        callback, true);
-  } else {
-    this.callInjectedScript_('getProperties', objectProxy,
-        ignoreHasOwnProperty, callback);
-  }
-};
-
-
 /**
  * @override
  */
@@ -269,21 +251,6 @@ devtools.InspectorControllerImpl.prototype.dispatchOnInjectedScript = function(
 };
 
 
-/**
- * This method allows calling a methods on InjectedScript object in the
- * inspected page.
- */
-devtools.InspectorControllerImpl.prototype.callInjectedScript_ =
-    function(methodName, var_arg) {
-  var allArgs = Array.prototype.slice.call(arguments);
-  var callback = allArgs[allArgs.length - 1];
-  var args = Array.prototype.slice.call(allArgs, 0, allArgs.length - 1);
-  RemoteToolsAgent.ExecuteUtilityFunction(
-      devtools.InspectorControllerImpl.parseWrap_(callback),
-      'InjectedScript', JSON.stringify(args));
-};
-
-
 /**
  * Installs delegating handler into the inspector controller.
  * @param {string} methodName Method to install delegating handler for.