Commit 4aad357d authored by Kinuko Yasuda's avatar Kinuko Yasuda Committed by Commit Bot

Disable flaky SafetyTipPageInfoBubbleViewBrowserTest tests

Already disabled on Mac, but very flaky on Win/Linux too

TBR=jdeblasio@chromium.org

Bug: 1139955
Change-Id: I7d8b8e79adf4b280d2ed092c33423cc6fceec096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493584
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820105}
parent 36b9f13c
......@@ -854,14 +854,9 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
}
// Tests that the SafetyTipShown histogram triggers correctly.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC)
#define MAYBE_SafetyTipShownHistogram DISABLED_SafetyTipShownHistogram
#else
#define MAYBE_SafetyTipShownHistogram SafetyTipShownHistogram
#endif
// Flaky on all platforms: https://crbug.com/1139955
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
MAYBE_SafetyTipShownHistogram) {
DISABLE_SafetyTipShownHistogram) {
const char kHistogramName[] = "Security.SafetyTips.SafetyTipShown";
base::HistogramTester histograms;
......@@ -1275,16 +1270,10 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
// Tests that UKM data is only recorded after the safety tip warning is
// dismissed or accepted, for the blocklist heuristic.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC)
#define MAYBE_WarningDismissalCausesUkmRecordingForBlocklist \
DISABLED_WarningDismissalCausesUkmRecordingForBlocklist
#else
#define MAYBE_WarningDismissalCausesUkmRecordingForBlocklist \
WarningDismissalCausesUkmRecordingForBlocklist
#endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
MAYBE_WarningDismissalCausesUkmRecordingForBlocklist) {
// Flaky on all platforms: https://crbug.com/1139955
IN_PROC_BROWSER_TEST_P(
SafetyTipPageInfoBubbleViewBrowserTest,
DISABLED_WarningDismissalCausesUkmRecordingForBlocklist) {
// Only test when any UI is actually enabled.
if (!IsSuspiciousSiteWarningEnabled()) {
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment