Commit 4b1ab4dc authored by finnur@chromium.org's avatar finnur@chromium.org

Show the full extension information in the extension controlled setting bubble...

Show the full extension information in the extension controlled setting bubble for Default search engines.

Also fix the glitch where the bubble popping up from the Default Search Engine list (DSE) appearing behind a selected row in the Other Search Engine list (OSE). That is fixed by making the OSE list have a lower z-index within the stacking context than the DSE.

BUG=314507
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/181293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255931 0039d316-1c4b-4281-b951-d872f2087c98
parent adbae2a3
......@@ -78,4 +78,12 @@
display: none;
}
#default-search-engine-list {
z-index: 2;
}
#other-search-engine-list {
z-index: 1;
}
/* End temporary Make Default button styling */
......@@ -186,9 +186,8 @@ cr.define('options.search_engines', function() {
// CoreOptionsHandler::CreateValueForPref() does.
var event = new Event(this.contentType);
if (engine.extension) {
event.value = { controlledBy: 'extension' };
// TODO(mad): add id, name, and icon once we solved the issue with the
// search engine manager in http://crbug.com/314507.
event.value = { controlledBy: 'extension',
extension: engine.extension };
} else {
event.value = { controlledBy: 'policy' };
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment