Commit 4c9b6b65 authored by Javier Ernesto Flores Robles's avatar Javier Ernesto Flores Robles Committed by Commit Bot

[iOS][Biometric-Auth] Add feature flag

Bug: 1112785
Change-Id: I99a228547d7907c2e9825d72da70a9d96b1f2206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335195Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794953}
parent 16e50847
...@@ -1202,6 +1202,11 @@ ...@@ -1202,6 +1202,11 @@
"owners": [ "fhorschig@chromium.org" ], "owners": [ "fhorschig@chromium.org" ],
"expiry_milestone": 87 "expiry_milestone": 87
}, },
{
"name": "enable-autofill-password-reauth-ios",
"owners": [ "javierrobles", "bling-flags" ],
"expiry_milestone": 90
},
{ {
"name": "enable-autofill-refresh-style", "name": "enable-autofill-refresh-style",
"owners": [ "tmartino@chromium.org" ], "owners": [ "tmartino@chromium.org" ],
......
...@@ -684,6 +684,10 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -684,6 +684,10 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flag_descriptions::kIOSLegacyTLSInterstitialsName, flag_descriptions::kIOSLegacyTLSInterstitialsName,
flag_descriptions::kIOSLegacyTLSInterstitialsDescription, flags_ui::kOsIos, flag_descriptions::kIOSLegacyTLSInterstitialsDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(web::features::kIOSLegacyTLSInterstitial)}, FEATURE_VALUE_TYPE(web::features::kIOSLegacyTLSInterstitial)},
{"enable-autofill-password-reauth-ios",
flag_descriptions::kEnableAutofillPasswordReauthIOSName,
flag_descriptions::kEnableAutofillPasswordReauthIOSDescription,
flags_ui::kOsIos, FEATURE_VALUE_TYPE(kEnableAutofillPasswordReauthIOS)},
}; };
bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) { bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
......
...@@ -229,6 +229,12 @@ const char kEnableAutofillCacheServerCardInfoDescription[] = ...@@ -229,6 +229,12 @@ const char kEnableAutofillCacheServerCardInfoDescription[] =
"If enabled, when a server card is unmasked, its info will be cached until " "If enabled, when a server card is unmasked, its info will be cached until "
"page navigation to simplify consecutive fills on the same page."; "page navigation to simplify consecutive fills on the same page.";
const char kEnableAutofillPasswordReauthIOSName[] =
"Enable Autofill reauth request for passwords";
const char kEnableAutofillPasswordReauthIOSDescription[] =
"If enabled, when a credential will be filled, the browser will require "
"the user to authenticate with the device first.";
const char kEnableClipboardProviderImageSuggestionsName[] = const char kEnableClipboardProviderImageSuggestionsName[] =
"Enable copied image provider"; "Enable copied image provider";
const char kEnableClipboardProviderImageSuggestionsDescription[] = const char kEnableClipboardProviderImageSuggestionsDescription[] =
......
...@@ -192,6 +192,10 @@ extern const char kEmbedderBlockRestoreUrlDescription[]; ...@@ -192,6 +192,10 @@ extern const char kEmbedderBlockRestoreUrlDescription[];
extern const char kEnableAutofillCacheServerCardInfoName[]; extern const char kEnableAutofillCacheServerCardInfoName[];
extern const char kEnableAutofillCacheServerCardInfoDescription[]; extern const char kEnableAutofillCacheServerCardInfoDescription[];
// Title and description for the flag to enable reauth for filling passwords.
extern const char kEnableAutofillPasswordReauthIOSName[];
extern const char kEnableAutofillPasswordReauthIOSDescription[];
// Title and description for the flag to enable the clipboard provider to // Title and description for the flag to enable the clipboard provider to
// suggest searchihng for copied images. // suggest searchihng for copied images.
extern const char kEnableClipboardProviderImageSuggestionsName[]; extern const char kEnableClipboardProviderImageSuggestionsName[];
......
...@@ -62,3 +62,6 @@ const base::Feature kSharedHighlightingIOS{"SharedHighlightingIOS", ...@@ -62,3 +62,6 @@ const base::Feature kSharedHighlightingIOS{"SharedHighlightingIOS",
const base::Feature kEnableFullPageScreenshot{ const base::Feature kEnableFullPageScreenshot{
"EnableFullPageScreenshot", base::FEATURE_DISABLED_BY_DEFAULT}; "EnableFullPageScreenshot", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kEnableAutofillPasswordReauthIOS{
"EnableAutofillPasswordReauthIOS", base::FEATURE_DISABLED_BY_DEFAULT};
...@@ -69,4 +69,7 @@ extern const base::Feature kSharedHighlightingIOS; ...@@ -69,4 +69,7 @@ extern const base::Feature kSharedHighlightingIOS;
// Feature flag that enables taking fullpage screenshots of a webpage. // Feature flag that enables taking fullpage screenshots of a webpage.
extern const base::Feature kEnableFullPageScreenshot; extern const base::Feature kEnableFullPageScreenshot;
// Feature flag that enables reauth for filling passwords;
extern const base::Feature kEnableAutofillPasswordReauthIOS;
#endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_ #endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment