Skip to content

GitLab

T
tangled
Commit 4cbe928a authored by jochen's avatar jochen Committed by Commit bot
Browse files
Options

Cleanup V8 histograms 

- mark obsolete histograms as such
- update descriptions and owners for current histograms
- add missing histograms

BUG=none
R=asvitkine@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/563853003

Cr-Commit-Position: refs/heads/master@{#295054}
parent f1c95054
Hide whitespace changes
Inline Side-by-side
Showing with 98 additions and 68 deletions
tools/metrics/histograms/histograms.xml
View file @ 4cbe928a
......@@ -35742,16 +35742,25 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="V8.ASTOptimization">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.CodeCreation">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.CodeGeneration">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent generating native code for functions.</summary>
</histogram>
......@@ -35765,62 +35774,89 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
<histogram name="V8.Compile">
<histogram name="V8.Compile" units="milliseconds">
<owner>jochen@chromium.org</owner>
<summary>Time spent in V8 compiler.</summary>
<owner>yangguo@chromium.org</owner>
<summary>Time spent in V8 compiler (full codegen).</summary>
</histogram>
<histogram name="V8.CompileEval">
<histogram name="V8.CompileEval" units="milliseconds">
<owner>jochen@chromium.org</owner>
<summary>Time spent in V8 compiler for eval.</summary>
<owner>yangguo@chromium.org</owner>
<summary>Time spent in V8 compiler (full codegen) for eval.</summary>
</histogram>
<histogram name="V8.CompileLazy">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent compiling functions lazily on first run.</summary>
</histogram>
<histogram name="V8.DeferredCodeGeneration">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent generating deferred code stubs.</summary>
</histogram>
<histogram name="V8.ExecutableMemoryMax" units="bytes">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>
The maximum memory used to store V8 compiled code on a given process.
</summary>
</histogram>
<histogram name="V8.GCCompactor">
<histogram name="V8.GCCompactor" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<summary>Time spent in mark-sweep phase of GC.</summary>
</histogram>
<histogram name="V8.GCContext">
<histogram name="V8.GCContext" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<summary>
Time spent GC'ing on context creation to get rid of older contexts.
</summary>
<owner>hpayer@chromium.org</owner>
<summary>Time spent doing a full GC during an IdleNotification.</summary>
</histogram>
<histogram name="V8.GCScavenger">
<histogram name="V8.GCIdleNotification" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>Time spent in IdleNotifications.</summary>
</histogram>
<histogram name="V8.GCIdleTimeAllottedInMS" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>Idle time passed to V8 via IdleNotifications.</summary>
</histogram>
<histogram name="V8.GCIncrementalMarking" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>Time spent doing incremental marking steps during GC.</summary>
</histogram>
<histogram name="V8.GCLowMemoryNotification" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>Time spent in LowMemoryNotifications.</summary>
</histogram>
<histogram name="V8.GCScavenger" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<summary>Time spent in scavenging phase of GC.</summary>
</histogram>
<histogram name="V8.MemoryExternalFragmentationCellSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the cell space after each GC in percent.
</summary>
......@@ -35828,8 +35864,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationCodeSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the code space after each GC in percent.
</summary>
......@@ -35837,8 +35872,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationLoSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the large object space after each GC in
percent.
......@@ -35847,8 +35881,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationMapSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the map space after each GC in percent.
</summary>
......@@ -35856,8 +35889,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationOldDataSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the old data space after each GC in
percent.
......@@ -35866,8 +35898,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationOldPointerSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
External memory fragmentation in the old pointer space after each GC in
percent.
......@@ -35876,8 +35907,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryExternalFragmentationTotal" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Total external memory fragmentation after each GC in percent.
</summary>
......@@ -35885,9 +35915,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionCellSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the cell space after each GC in percent.
</summary>
......@@ -35895,9 +35923,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionCodeSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the code space after each GC in percent.
</summary>
......@@ -35905,9 +35931,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionLoSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the lo space after each GC in percent.
</summary>
......@@ -35915,9 +35939,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionMapSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the map space after each GC in percent.
</summary>
......@@ -35925,9 +35947,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionNewSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the new space after each GC in percent.
</summary>
......@@ -35935,9 +35955,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionOldDataSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the old data space after each GC in
percent.
......@@ -35946,9 +35964,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapFractionOldPointerSpace" units="percent">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
Fraction of the total heap used by the old pointer space after each GC in
percent.
......@@ -35957,8 +35973,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleCellSpaceCommitted" units="KB">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
The size of committed memory in the cell space after each GC in KB.
</summary>
......@@ -35966,8 +35981,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleCodeSpaceCommitted" units="KB">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
The size of committed memory in the code space after each GC in KB.
</summary>
......@@ -35975,8 +35989,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleMapSpaceCommitted" units="KB">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
The size of committed memory in the map space after each GC in KB.
</summary>
......@@ -35984,9 +35997,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleTotalCommitted" units="KB">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
The total size of committed memory used by V8 after each GC in KB.
</summary>
......@@ -35994,57 +36005,76 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="V8.MemoryHeapSampleTotalUsed" units="KB">
<owner>jochen@chromium.org</owner>
<owner>hajimehoshi@chromium.org</owner>
<owner>kouhei@chromium.org</owner>
<owner>rmcilroy@chromium.org</owner>
<owner>hpayer@chromium.org</owner>
<summary>
The total size of live memory used by V8 after each GC in KB.
</summary>
</histogram>
<histogram name="V8.Parse">
<histogram name="V8.Parse" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>marja@chromium.org</owner>
<summary>Time spent in V8 parser.</summary>
</histogram>
<histogram name="V8.ParseLazy">
<histogram name="V8.ParseLazy" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>marja@chromium.org</owner>
<summary>
Time spent parsing functions when they are lazily compiled on first run.
</summary>
</histogram>
<histogram name="V8.PreParse">
<histogram name="V8.PreParse" units="milliseconds">
<owner>jochen@chromium.org</owner>
<owner>marja@chromium.org</owner>
<summary>Time spent preparsing source code.</summary>
</histogram>
<histogram name="V8.Rewriting">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent on rewriting ASTs before compilation.</summary>
</histogram>
<histogram name="V8.RSetLO">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.RSetPaged">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
<histogram name="V8.ScriptCache">
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
<owner>yangguo@chromium.org</owner>
<summary>
The generation a compiled script was found in the compilation cache.
</summary>
</histogram>
<histogram name="V8.UsageAnalysis">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>Time spent analysing the usage of variables.</summary>
</histogram>
<histogram name="V8.VariableAllocation">
<obsolete>
This histogram is no longer present in V8
</obsolete>
<owner>jochen@chromium.org</owner>
<summary>TBD</summary>
</histogram>
......@@ -55365,7 +55395,7 @@ To add a new entry, add it with any value and run test to compute valid value.
</histogram_suffixes>
<histogram_suffixes name="V8SpecialApps" separator=".">
<suffix name="docs" label="Custom histogram for Google Docs"/>
<suffix name="docs" label="Custom histogram for Google Docs and Drive"/>
<suffix name="gmail" label="Custom histogram for GMail"/>
<suffix name="plus" label="Custom histogram for Google+"/>
<affected-histogram name="V8.MemoryExternalFragmentationTotal"/>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment