Commit 4d26072c authored by Alice Wang's avatar Alice Wang Committed by Commit Bot

[Android][Signin] Enable disabled signin helper test

This CL enables the disabled signin helper test.

Bug: 577880
Change-Id: I14d5f818a1b091b6392dca8083c217e179993239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942089Reviewed-by: default avatarBoris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720903}
parent 0c2fd9a3
...@@ -14,7 +14,6 @@ import org.junit.Rule; ...@@ -14,7 +14,6 @@ import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.RetryOnFailure; import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.test.ChromeJUnit4ClassRunner; import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
import org.chromium.chrome.test.util.browser.signin.MockChangeEventChecker; import org.chromium.chrome.test.util.browser.signin.MockChangeEventChecker;
...@@ -84,13 +83,12 @@ public class SigninHelperTest { ...@@ -84,13 +83,12 @@ public class SigninHelperTest {
} }
@Test @Test
@DisabledTest(message = "crbug.com/568623")
@SmallTest @SmallTest
public void testNotSignedInAccountRename() { public void testNotSignedInAccountRename() {
setSignedInAccountName("A"); setSignedInAccountName("A");
mEventChecker.insertRenameEvent("B", "C"); mEventChecker.insertRenameEvent("B", "C");
SigninHelper.updateAccountRenameData(mEventChecker); SigninHelper.updateAccountRenameData(mEventChecker);
Assert.assertEquals(null, getNewSignedInAccountName()); Assert.assertNull(getNewSignedInAccountName());
} }
@Test @Test
...@@ -113,7 +111,7 @@ public class SigninHelperTest { ...@@ -113,7 +111,7 @@ public class SigninHelperTest {
mEventChecker.insertRenameEvent("B", "C"); mEventChecker.insertRenameEvent("B", "C");
mEventChecker.insertRenameEvent("C", "D"); mEventChecker.insertRenameEvent("C", "D");
SigninHelper.updateAccountRenameData(mEventChecker); SigninHelper.updateAccountRenameData(mEventChecker);
Assert.assertEquals(null, getNewSignedInAccountName()); Assert.assertNull(getNewSignedInAccountName());
} }
@Test @Test
...@@ -152,10 +150,6 @@ public class SigninHelperTest { ...@@ -152,10 +150,6 @@ public class SigninHelperTest {
ChromeSigninController.get().setSignedInAccountName(account); ChromeSigninController.get().setSignedInAccountName(account);
} }
private String getSignedInAccountName() {
return ChromeSigninController.get().getSignedInAccountName();
}
private String getNewSignedInAccountName() { private String getNewSignedInAccountName() {
return SigninHelper.getNewSignedInAccountName(); return SigninHelper.getNewSignedInAccountName();
} }
......
...@@ -18,8 +18,7 @@ import java.util.Map; ...@@ -18,8 +18,7 @@ import java.util.Map;
*/ */
public final class MockChangeEventChecker public final class MockChangeEventChecker
implements SigninHelper.AccountChangeEventChecker { implements SigninHelper.AccountChangeEventChecker {
private Map<String, List<String>> mEvents = private Map<String, List<String>> mEvents = new HashMap<>();
new HashMap<String, List<String>>();
@Override @Override
public List<String> getAccountChangeEvents( public List<String> getAccountChangeEvents(
...@@ -36,7 +35,7 @@ public final class MockChangeEventChecker ...@@ -36,7 +35,7 @@ public final class MockChangeEventChecker
private List<String> getEventList(String account) { private List<String> getEventList(String account) {
List<String> eventsList = mEvents.get(account); List<String> eventsList = mEvents.get(account);
if (eventsList == null) { if (eventsList == null) {
eventsList = new ArrayList<String>(); eventsList = new ArrayList<>();
mEvents.put(account, eventsList); mEvents.put(account, eventsList);
} }
return eventsList; return eventsList;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment