Commit 4dcf6114 authored by Joshua Bell's avatar Joshua Bell Committed by Commit Bot

Retire WebLocksAPI runtime enabled flag.

Feature shipped in M69

Bug: 862455
Change-Id: Ie729a201fe30449123dcc22147301b152a5ff327
Reviewed-on: https://chromium-review.googlesource.com/c/1338721
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: default avatarRick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611535}
parent 604a85fc
...@@ -5,8 +5,7 @@ ...@@ -5,8 +5,7 @@
// https://wicg.github.io/web-locks/#lock // https://wicg.github.io/web-locks/#lock
[ [
SecureContext, SecureContext,
Exposed=(Window,Worker), Exposed=(Window,Worker)
RuntimeEnabled=WebLocksAPI
] interface Lock { ] interface Lock {
readonly attribute DOMString name; readonly attribute DOMString name;
readonly attribute LockMode mode; readonly attribute LockMode mode;
......
...@@ -8,8 +8,7 @@ callback LockGrantedCallback = any (Lock? lock); ...@@ -8,8 +8,7 @@ callback LockGrantedCallback = any (Lock? lock);
// https://wicg.github.io/web-locks/#lockmanager // https://wicg.github.io/web-locks/#lockmanager
[ [
SecureContext, SecureContext,
Exposed=(Window,Worker), Exposed=(Window,Worker)
RuntimeEnabled=WebLocksAPI
] interface LockManager { ] interface LockManager {
[CallWith=ScriptState, RaisesException, Measure] Promise<Lock> request( [CallWith=ScriptState, RaisesException, Measure] Promise<Lock> request(
DOMString name, DOMString name,
......
...@@ -6,8 +6,7 @@ ...@@ -6,8 +6,7 @@
[ [
SecureContext, SecureContext,
Exposed=Window, Exposed=Window,
ImplementedAs=NavigatorLocks, ImplementedAs=NavigatorLocks
RuntimeEnabled=WebLocksAPI
] partial interface Navigator { ] partial interface Navigator {
[CallWith=ScriptState] readonly attribute LockManager locks; [CallWith=ScriptState] readonly attribute LockManager locks;
}; };
...@@ -6,8 +6,7 @@ ...@@ -6,8 +6,7 @@
[ [
SecureContext, SecureContext,
Exposed=Worker, Exposed=Worker,
ImplementedAs=NavigatorLocks, ImplementedAs=NavigatorLocks
RuntimeEnabled=WebLocksAPI
] partial interface WorkerNavigator { ] partial interface WorkerNavigator {
[CallWith=ScriptState] readonly attribute LockManager locks; [CallWith=ScriptState] readonly attribute LockManager locks;
}; };
...@@ -1354,10 +1354,6 @@ ...@@ -1354,10 +1354,6 @@
name: "WebGPU", name: "WebGPU",
status: "test", status: "test",
}, },
{
name: "WebLocksAPI",
status: "stable",
},
{ {
name: "WebNFC", name: "WebNFC",
status: "experimental", status: "experimental",
......
importScripts('/resources/testharness.js',
'/resources/origin-trials-helper.js');
test(t => {
OriginTrialsHelper.check_interfaces_missing(
self,
['LockManager', 'Lock']);
}, 'Web Locks API interfaces in Origin-Trial disabled worker.');
test(t => {
assert_false('locks' in self.navigator,
'locks property does not exist on navigator');
}, 'Web Locks API entry point in Origin-Trial disabled worker.');
done();
<?php
// Generate token with the command:
// generate_token.py http://127.0.0.1:8000 WebLocksAPI --expire-timestamp=2000000000
header("Origin-Trial: Aq40kr/ZTqxmfeh35cvBQcwBrmiL7pSDR6PrUZaVC7xxGe3ff4fECD/TdP+w+Ic9cXZ1ek6N4kg6oR876PQd/QoAAABTeyJvcmlnaW4iOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiwgImZlYXR1cmUiOiAiV2ViTG9ja3NBUEkiLCAiZXhwaXJ5IjogMjAwMDAwMDAwMH0=");
header('Content-Type: application/javascript');
?>
importScripts('/resources/testharness.js',
'/resources/origin-trials-helper.js');
test(t => {
OriginTrialsHelper.check_properties(this,
{'LockManager': ['request', 'query'],
'Lock': ['name', 'mode'],
});
}, 'Web Locks API interfaces and properties in Origin-Trial enabled serviceworker.');
test(t => {
assert_true('locks' in self.navigator, 'locks property exists on navigator');
}, 'Web Locks API entry point in Origin-Trial enabled serviceworker.');
done();
importScripts('/resources/testharness.js',
'/resources/origin-trials-helper.js');
test(t => {
OriginTrialsHelper.check_properties(this,
{'LockManager': ['request', 'query'],
'Lock': ['name', 'mode'],
});
}, 'Web Locks API interfaces and properties in Origin-Trial enabled worker.');
test(t => {
assert_true('locks' in self.navigator, 'locks property exists on navigator');
}, 'Web Locks API entry point in Origin-Trial enabled worker.');
done();
<!DOCTYPE html>
<meta charset="utf-8">
<!-- Generate token with the command:
generate_token.py http://127.0.0.1:8000 WebLocksAPI --expire-timestamp=2000000000
-- -->
<meta http-equiv="origin-trial" content="Aq40kr/ZTqxmfeh35cvBQcwBrmiL7pSDR6PrUZaVC7xxGe3ff4fECD/TdP+w+Ic9cXZ1ek6N4kg6oR876PQd/QoAAABTeyJvcmlnaW4iOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiwgImZlYXR1cmUiOiAiV2ViTG9ja3NBUEkiLCAiZXhwaXJ5IjogMjAwMDAwMDAwMH0=" />
<title>Web Locks API - interfaces exposed by origin trial</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/origin-trials-helper.js"></script>
<script src="/serviceworker/resources/test-helpers.js"></script>
<script>
test(t => {
OriginTrialsHelper.check_properties(this,
{'LockManager': ['request', 'query'],
'Lock': ['name', 'mode'],
});
}, 'Web Locks API interfaces and properties in Origin-Trial enabled document.');
test(t => {
assert_true('locks' in self.navigator, 'locks property exists on navigator');
}, 'Web Locks API entry point in Origin-Trial enabled document.');
fetch_tests_from_worker(new Worker('resources/weblocksapi-origin-trial-interfaces-worker.js'));
// Only run "disabled" tests if the feature is not enabled via runtime flags.
if (!self.internals.runtimeFlags.webLocksAPIEnabled) {
service_worker_test('resources/weblocksapi-origin-trial-interfaces-serviceworker-disabled.js');
}
service_worker_test('resources/weblocksapi-origin-trial-interfaces-serviceworker-enabled.php');
</script>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment