Commit 4de7bcf1 authored by Mike Jackson's avatar Mike Jackson Committed by Chromium LUCI CQ

dpwas: Clean up comments that reference crbug.com/897302

No product code changes, just updating comments, and removing TODOs.

Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md
I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ

Bug: 897302
Change-Id: Id8f1a8e9bfbb3435f3b653d6b9a587279b401fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637265Reviewed-by: default avatarChase Phillips <cmp@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845320}
parent 3f12512d
...@@ -514,7 +514,7 @@ void OsIntegrationManager::OnShortcutsCreated( ...@@ -514,7 +514,7 @@ void OsIntegrationManager::OnShortcutsCreated(
if (options.os_hooks[OsHookType::kRunOnOsLogin] && if (options.os_hooks[OsHookType::kRunOnOsLogin] &&
base::FeatureList::IsEnabled(features::kDesktopPWAsRunOnOsLogin)) { base::FeatureList::IsEnabled(features::kDesktopPWAsRunOnOsLogin)) {
// TODO(crbug.com/897302): Implement Run on OS Login mode selection. // TODO(crbug.com/1091964): Implement Run on OS Login mode selection.
// Currently it is set to be the default: RunOnOsLoginMode::kWindowed // Currently it is set to be the default: RunOnOsLoginMode::kWindowed
RegisterRunOnOsLogin(app_id, barrier->CreateBarrierCallbackForType( RegisterRunOnOsLogin(app_id, barrier->CreateBarrierCallbackForType(
OsHookType::kRunOnOsLogin)); OsHookType::kRunOnOsLogin));
......
...@@ -35,16 +35,14 @@ namespace internals { ...@@ -35,16 +35,14 @@ namespace internals {
// TODO(crbug.com/1052397): Revisit once build flag switch of lacros-chrome is // TODO(crbug.com/1052397): Revisit once build flag switch of lacros-chrome is
// complete. // complete.
#if !(defined(OS_WIN) || defined(OS_MAC) || (defined(OS_LINUX) || BUILDFLAG(IS_CHROMEOS_LACROS))) #if !(defined(OS_WIN) || defined(OS_MAC) || (defined(OS_LINUX) || BUILDFLAG(IS_CHROMEOS_LACROS)))
// TODO(crbug.com/897302): This boilerplate function is used for platforms // This boilerplate function is used for platforms that don't support Run On OS
// that don't support Run On OS Login. Currently the feature is supported on // Login. Currently the feature is supported on Windows, Linux and MacOS.
// Windows, Linux and MacOS.
bool RegisterRunOnOsLogin(const ShortcutInfo& shortcut_info) { bool RegisterRunOnOsLogin(const ShortcutInfo& shortcut_info) {
return false; return false;
} }
// TODO(crbug.com/897302): This boilerplate function is used for platforms // This boilerplate function is used for platforms that don't support Run On OS
// that don't support Run On OS Login. Currently the feature is supported on // Login. Currently the feature is supported on Windows, Linux and MacOS.
// Windows, Linux and MacOS.
bool UnregisterRunOnOsLogin(const std::string& app_id, bool UnregisterRunOnOsLogin(const std::string& app_id,
const base::FilePath& profile_path, const base::FilePath& profile_path,
const base::string16& shortcut_title) { const base::string16& shortcut_title) {
......
...@@ -94,7 +94,8 @@ struct ShortcutLocations { ...@@ -94,7 +94,8 @@ struct ShortcutLocations {
bool in_quick_launch_bar; bool in_quick_launch_bar;
// For Windows, this refers to the Startup folder. // For Windows, this refers to the Startup folder.
// TODO(crbug.com/897302): where to create shortcuts in other OS. // For Mac, this refers to the Login Items list.
// For Linux, this refers to the autostart folder.
bool in_startup; bool in_startup;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment