Commit 4fa2e0a4 authored by Uladzimir Miniailau's avatar Uladzimir Miniailau Committed by Commit Bot

kEnableManualFallbacksFillingStandalone -> kManualFallbacksFillingStandalone

Remove unnecessary "Enable" from a password manager feature name.

Bug: 785953
Change-Id: Ifafb1302ed5563dbeef00228cb90555515ecd1d7
Reviewed-on: https://chromium-review.googlesource.com/1105990
Commit-Queue: Uladzimir Miniailau <miniailau@google.com>
Reviewed-by: default avatarVaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568457}
parent 22ad9766
...@@ -365,7 +365,7 @@ class PasswordAutofillAgentTest : public ChromeRenderViewTest { ...@@ -365,7 +365,7 @@ class PasswordAutofillAgentTest : public ChromeRenderViewTest {
void SetManualFallbacksStandalone() { void SetManualFallbacksStandalone() {
scoped_feature_list_.InitAndEnableFeature( scoped_feature_list_.InitAndEnableFeature(
password_manager::features::kEnableManualFallbacksFillingStandalone); password_manager::features::kManualFallbacksFillingStandalone);
} }
void EnableShowAutofillSignatures() { void EnableShowAutofillSignatures() {
......
...@@ -606,7 +606,7 @@ bool ShouldShowStandaloneManuallFallback(const blink::WebInputElement& element, ...@@ -606,7 +606,7 @@ bool ShouldShowStandaloneManuallFallback(const blink::WebInputElement& element,
!base::StartsWith(url.scheme(), "chrome", base::CompareCase::SENSITIVE) && !base::StartsWith(url.scheme(), "chrome", base::CompareCase::SENSITIVE) &&
!url.SchemeIs(url::kAboutScheme) && !url.SchemeIs(url::kAboutScheme) &&
base::FeatureList::IsEnabled( base::FeatureList::IsEnabled(
password_manager::features::kEnableManualFallbacksFillingStandalone)); password_manager::features::kManualFallbacksFillingStandalone));
} }
PasswordForm::SubmissionIndicatorEvent ToSubmissionIndicatorEvent( PasswordForm::SubmissionIndicatorEvent ToSubmissionIndicatorEvent(
......
...@@ -178,10 +178,10 @@ class PasswordAutofillManagerTest : public testing::Test { ...@@ -178,10 +178,10 @@ class PasswordAutofillManagerTest : public testing::Test {
void SetManualFallbacksForFillingStandalone(bool enabled) { void SetManualFallbacksForFillingStandalone(bool enabled) {
if (enabled) { if (enabled) {
scoped_feature_list_.InitAndEnableFeature( scoped_feature_list_.InitAndEnableFeature(
password_manager::features::kEnableManualFallbacksFillingStandalone); password_manager::features::kManualFallbacksFillingStandalone);
} else { } else {
scoped_feature_list_.InitAndDisableFeature( scoped_feature_list_.InitAndDisableFeature(
password_manager::features::kEnableManualFallbacksFillingStandalone); password_manager::features::kManualFallbacksFillingStandalone);
} }
} }
...@@ -194,7 +194,7 @@ class PasswordAutofillManagerTest : public testing::Test { ...@@ -194,7 +194,7 @@ class PasswordAutofillManagerTest : public testing::Test {
void SetManualFallbacks(bool enabled) { void SetManualFallbacks(bool enabled) {
std::vector<std::string> features = { std::vector<std::string> features = {
password_manager::features::kManualFallbacksFilling.name, password_manager::features::kManualFallbacksFilling.name,
password_manager::features::kEnableManualFallbacksFillingStandalone password_manager::features::kManualFallbacksFillingStandalone
.name, .name,
password_manager::features::kEnableManualFallbacksGeneration.name}; password_manager::features::kEnableManualFallbacksGeneration.name};
if (enabled) { if (enabled) {
......
...@@ -30,9 +30,8 @@ const base::Feature kManualFallbacksFilling = { ...@@ -30,9 +30,8 @@ const base::Feature kManualFallbacksFilling = {
// Enable a standalone popup UI, which will allow the user to view all saved // Enable a standalone popup UI, which will allow the user to view all saved
// passwords. // passwords.
const base::Feature kEnableManualFallbacksFillingStandalone = { const base::Feature kManualFallbacksFillingStandalone = {
"EnableManualFallbacksFillingStandalone", "ManualFallbacksFillingStandalone", base::FEATURE_DISABLED_BY_DEFAULT};
base::FEATURE_DISABLED_BY_DEFAULT};
// Enable a context menu item in the password field that allows the user // Enable a context menu item in the password field that allows the user
// to manually enforce saving of their password. // to manually enforce saving of their password.
......
...@@ -20,7 +20,7 @@ namespace features { ...@@ -20,7 +20,7 @@ namespace features {
extern const base::Feature kAffiliationBasedMatching; extern const base::Feature kAffiliationBasedMatching;
extern const base::Feature kHtmlBasedUsernameDetector; extern const base::Feature kHtmlBasedUsernameDetector;
extern const base::Feature kManualFallbacksFilling; extern const base::Feature kManualFallbacksFilling;
extern const base::Feature kEnableManualFallbacksFillingStandalone; extern const base::Feature kManualFallbacksFillingStandalone;
extern const base::Feature kEnableManualFallbacksGeneration; extern const base::Feature kEnableManualFallbacksGeneration;
extern const base::Feature kEnableManualPasswordGeneration; extern const base::Feature kEnableManualPasswordGeneration;
extern const base::Feature kPasswordGenerationRequirements; extern const base::Feature kPasswordGenerationRequirements;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment