Commit 50ca45ad authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot

Update ink overflow test when applying outline

The test is to check |NeedsLayout| when outline is applied,
but the current test may set |NeedsLayout| because it changes
a culled inline box to a non-culled inline box.

This patch changes the test to make sure the inline box is
not culled before applying the outline.

This patch does not fix the issue, but makes sure to change
the test result when we fix this problem for outline.

Bug: 1128199
Change-Id: I92262fa77d29b239c23362cf10edbb9da51382dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442395
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812620}
parent 4c161e98
...@@ -607,7 +607,9 @@ struct StyleChangeData { ...@@ -607,7 +607,9 @@ struct StyleChangeData {
// require layout, only ink overflow, but they currently do. // require layout, only ink overflow, but they currently do.
{"#parent.after { text-decoration-line: underline; }", {"#parent.after { text-decoration-line: underline; }",
StyleChangeData::kNone, true, true}, StyleChangeData::kNone, true, true},
{"#parent.after { outline: auto; }", StyleChangeData::kNone, true}, {"#parent { background: orange; }" // Make sure it's not culled.
"#parent.after { outline: auto; }",
StyleChangeData::kNone, true},
// Changing fonts should re-run |CollectInlines()|. // Changing fonts should re-run |CollectInlines()|.
{"#parent.after { font-size: 200%; }", StyleChangeData::kAll, true}, {"#parent.after { font-size: 200%; }", StyleChangeData::kAll, true},
// Changing from/to out-of-flow should re-rerun |CollectInlines()|. // Changing from/to out-of-flow should re-rerun |CollectInlines()|.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment