Commit 513d5e08 authored by Helen Li's avatar Helen Li Committed by Commit Bot

Minor fix on CronetStressTest.testLargeNumberOfUploads

Moves upload bytes out of the for-loop to use less memory on the stack.

Bug: 771366
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Icc1e20c8c6191f13c8889324699fd47bf8a1108c
Reviewed-on: https://chromium-review.googlesource.com/700482
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: default avatarAndrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506452}
parent bfbb56d2
......@@ -51,6 +51,7 @@ public class CronetStressTest {
final int kNumRequest = 1000;
final int kNumRequestHeaders = 100;
final int kNumUploadBytes = 1000;
final byte[] b = new byte[kNumUploadBytes];
for (int i = 0; i < kNumRequest; i++) {
TestUrlRequestCallback callback = new TestUrlRequestCallback();
UrlRequest.Builder builder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
......@@ -59,10 +60,10 @@ public class CronetStressTest {
builder.addHeader("header" + j, Integer.toString(j));
}
builder.addHeader("content-type", "useless/string");
byte[] b = new byte[kNumUploadBytes];
builder.setUploadDataProvider(
UploadDataProviders.create(b, 0, kNumUploadBytes), callback.getExecutor());
builder.build().start();
UrlRequest request = builder.build();
request.start();
callback.blockForDone();
assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment