Commit 51748f6b authored by Bo Liu's avatar Bo Liu Committed by Commit Bot

aw: Skip onPageStarted for in-page navigation

This matches old behavior. Note that fragment navigation is strict
subset of in-page navigations. in-page navigations also include
history.replaceState and history.pushState

Bug: 902722, 896022
Change-Id: I002fab4982620e7e13b84a7d96547e105c7338bb
Reviewed-on: https://chromium-review.googlesource.com/c/1345229Reviewed-by: default avatarRichard Coles <torne@chromium.org>
Reviewed-by: default avatarShimi Zhang <ctzsm@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609856}
parent 68548c41
......@@ -105,9 +105,10 @@ public class AwWebContentsObserver extends WebContentsObserver {
AwContentsClient client = mAwContentsClient.get();
if (client != null) {
// OnPageStarted is not called for fragment navigations.
// OnPageStarted is not called for in-page navigations, which include fragment
// navigations and navigation from history.push/replaceState.
// Error page is handled by AwContentsClientBridge.onReceivedError.
if (!isFragmentNavigation && !isErrorPage
if (!isSameDocument && !isErrorPage
&& AwFeatureList.pageStartedOnCommitEnabled(isRendererInitiated)) {
client.getCallbackHelper().postOnPageStarted(url);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment