Remove disable-progress-bar-animation flag

Flag has expired in M88

Change-Id: Ie67fc34e530e0cd4727dee064398de035948e8e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597877Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840961}

chrome/browser/flag-metadata.json

@@ -976,11 +976,6 @@
     ],
     "expiry_milestone": 88
   },
-  {
-    "name": "disable-progress-bar-animation",
-    "owners": [ "eugenebut", "djean", "bling-flags@google.com" ],
-    "expiry_milestone": 88
-  },
   {
     "name": "disable-threaded-scrolling",
     "owners": [ "bokan", "input-dev" ],

ios/chrome/browser/flags/about_flags.mm

@@ -389,10 +389,6 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kEmbedderBlockRestoreUrlName,
      flag_descriptions::kEmbedderBlockRestoreUrlDescription, flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(kEmbedderBlockRestoreUrl)},
-    {"disable-progress-bar-animation",
-     flag_descriptions::kDisableProgressBarAnimationName,
-     flag_descriptions::kDisableProgressBarAnimationDescription,
-     flags_ui::kOsIos, FEATURE_VALUE_TYPE(kDisableProgressBarAnimation)},
     {"messages-save-card-infobar",
      flag_descriptions::kSaveCardInfobarMessagesUIName,
      flag_descriptions::kSaveCardInfobarMessagesUIDescription, flags_ui::kOsIos,

ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc

@@ -154,11 +154,6 @@ const char kDetectMainThreadFreezeDescription[] =
     "A crash report will be uploaded if the main thread is frozen more than "
     "the time specified by this flag.";
 
-const char kDisableProgressBarAnimationName[] =
-    "Disable page load progress bar animation";
-const char kDisableProgressBarAnimationDescription[] =
-    "Disable progress bar animation when a page loads.";
-
 const char kDiscoverFeedInNtpName[] = "Enable new content Suggestion Feed";
 const char kDiscoverFeedInNtpDescription[] =
     "When enabled, replaces articles feed with new content Suggestion Feed in "

ios/chrome/browser/flags/ios_chrome_flag_descriptions.h

@@ -132,10 +132,6 @@ extern const char kDelayThresholdMinutesToUpdateGaiaCookieDescription[];
 extern const char kDetectMainThreadFreezeName[];
 extern const char kDetectMainThreadFreezeDescription[];
 
-// Title and description for the flag to disable progress bar animation.
-extern const char kDisableProgressBarAnimationName[];
-extern const char kDisableProgressBarAnimationDescription[];
-
 // Title and description for the flag to replace the Zine feed with the
 // Discover feed in the Bling NTP.
 extern const char kDiscoverFeedInNtpName[];

ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller.h

@@ -39,8 +39,6 @@
 // Returns the tools menu button.
 - (ToolbarToolsMenuButton*)toolsMenuButton;
 
-// Returns YES if animations are globally enabled in chrome.
-- (BOOL)areAnimationsEnabled;
 // Updates the view so a snapshot can be taken. It needs to be adapted,
 // depending on if it is a snapshot displayed |onNTP| or not.
 - (void)updateForSideSwipeSnapshotOnNTP:(BOOL)onNTP;

ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller.mm

@@ -56,10 +56,6 @@ const CGFloat kTabGridAnimationsTotalDuration = 0.5;
 
 #pragma mark - Public
 
-- (BOOL)areAnimationsEnabled {
-  return !base::FeatureList::IsEnabled(kDisableProgressBarAnimation);
-}
-
 - (void)updateForSideSwipeSnapshotOnNTP:(BOOL)onNTP {
   self.view.progressBar.hidden = YES;
   self.view.progressBar.alpha = 0;
@@ -159,9 +155,7 @@ const CGFloat kTabGridAnimationsTotalDuration = 0.5;
 }
 
 - (void)setLoadingProgressFraction:(double)progress {
-  [self.view.progressBar setProgress:progress
-                            animated:[self areAnimationsEnabled]
-                          completion:nil];
+  [self.view.progressBar setProgress:progress animated:YES completion:nil];
 }
 
 - (void)setTabCount:(int)tabCount addedInBackground:(BOOL)inBackground {
@@ -236,7 +230,7 @@ const CGFloat kTabGridAnimationsTotalDuration = 0.5;
 - (void)stopProgressBar {
   __weak AdaptiveToolbarViewController* weakSelf = self;
   [self.view.progressBar setProgress:1
-                            animated:[self areAnimationsEnabled]
+                            animated:YES
                           completion:^(BOOL finished) {
                             [weakSelf updateProgressBarVisibility];
                           }];
@@ -324,13 +318,13 @@ const CGFloat kTabGridAnimationsTotalDuration = 0.5;
   __weak __typeof(self) weakSelf = self;
   if (self.loading && self.view.progressBar.hidden) {
     [self.view.progressBar setHidden:NO
-                            animated:[self areAnimationsEnabled]
+                            animated:YES
                           completion:^(BOOL finished) {
                             [weakSelf updateProgressBarVisibility];
                           }];
   } else if (!self.loading && !self.view.progressBar.hidden) {
     [self.view.progressBar setHidden:YES
-                            animated:[self areAnimationsEnabled]
+                            animated:YES
                           completion:^(BOOL finished) {
                             [weakSelf updateProgressBarVisibility];
                           }];

ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm

@@ -52,7 +52,7 @@
   __weak PrimaryToolbarViewController* weakSelf = self;
   [self.view.progressBar setProgress:0];
   [self.view.progressBar setHidden:NO
-                          animated:[self areAnimationsEnabled]
+                          animated:YES
                         completion:^(BOOL finished) {
                           [weakSelf stopProgressBar];
                         }];

ios/chrome/browser/ui/ui_feature_flags.cc

@@ -19,9 +19,6 @@ const base::Feature kSettingsRefresh{"SettingsRefresh",
 const base::Feature kEmbedderBlockRestoreUrl{"EmbedderBlockRestoreUrl",
                                              base::FEATURE_DISABLED_BY_DEFAULT};
 
-const base::Feature kDisableProgressBarAnimation{
-    "DisableProgressBarAnimation", base::FEATURE_DISABLED_BY_DEFAULT};
-
 const base::Feature kVoiceOverUnstackedTabstrip{
     "VoiceOverUnstackedTabstrip", base::FEATURE_ENABLED_BY_DEFAULT};
 

ios/chrome/browser/ui/ui_feature_flags.h

@@ -20,9 +20,6 @@ extern const base::Feature kSettingsRefresh;
 // Feature flag for embedders to block restore urls.
 extern const base::Feature kEmbedderBlockRestoreUrl;
 
-// Feature flag disabling progress bar animation.
-extern const base::Feature kDisableProgressBarAnimation;
-
 // Feature flag to use the unstacked tabstrip when voiceover is enabled.
 extern const base::Feature kVoiceOverUnstackedTabstrip;