Revert "Add finalizers to Web Payment Java objects that own native objects"
This reverts commit 379dbfae. Reason for revert: Finalizers are banned in Chromium. These finalizers have been causing assertion failures due to being called on the background thread. Bug: 1129695 Original change's description: > Add finalizers to Web Payment Java objects that own native objects > > These C++ objects are destroyed in PaymentRequestImpl.closeUIAndDestroyNativeObjects(). > However, if an object is garbage-collected for any reason without > PaymentRequestImpl.closeUIAndDestroyNativeObjects() being called, > then it will cause a memory leak. > > A finalize method should be added to these objects to ensure destruction > of the owned C++ objects. > > Bug: 1090918 > Change-Id: I12df86f9705d81d630b63223d15354d2b022e888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392290 > Commit-Queue: DongJun Kim <djmix.kim@samsung.com> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804820} TBR=rouslan@chromium.org,djmix.kim@samsung.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090918 Change-Id: I7710d7065a7e225be3a331b0dec289506ee1d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422238Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808909}
Showing
Please register or sign in to comment