Commit 53263f3d authored by Mike Baxley's avatar Mike Baxley Committed by Commit Bot

Remove TODO to consolidate InfinitePendingResponseProvider.

Instead of sharing this code, it should be replaced by directly using
the Embedded Test Server.

Bug: 638674
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If887548078abe90314363a39c33980225239a523
Reviewed-on: https://chromium-review.googlesource.com/791810
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: default avatarMenglu Huang <huangml@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519742}
parent 32f03c7a
...@@ -72,7 +72,7 @@ id<GREYMatcher> ProgressViewWithProgress(CGFloat progress) { ...@@ -72,7 +72,7 @@ id<GREYMatcher> ProgressViewWithProgress(CGFloat progress) {
} }
// Response provider that serves the page which never finishes loading. // Response provider that serves the page which never finishes loading.
// TODO(crbug.com/638674): Evaluate if this can move to shared code. // TODO(crbug.com/708307): Convert this to Embedded Test Server.
class InfinitePendingResponseProvider : public HtmlResponseProvider { class InfinitePendingResponseProvider : public HtmlResponseProvider {
public: public:
explicit InfinitePendingResponseProvider(const GURL& url) explicit InfinitePendingResponseProvider(const GURL& url)
......
...@@ -30,6 +30,7 @@ namespace { ...@@ -30,6 +30,7 @@ namespace {
const char kPageText[] = "Navigation testing page"; const char kPageText[] = "Navigation testing page";
// Response provider that serves the page which never finishes loading. // Response provider that serves the page which never finishes loading.
// TODO(crbug.com/708307): Convert this to Embedded Test Server.
class InfinitePendingResponseProvider : public HtmlResponseProvider { class InfinitePendingResponseProvider : public HtmlResponseProvider {
public: public:
explicit InfinitePendingResponseProvider(const GURL& url) : url_(url) {} explicit InfinitePendingResponseProvider(const GURL& url) : url_(url) {}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment