Commit 54729971 authored by Mohamed Heikal's avatar Mohamed Heikal Committed by Commit Bot

Stop bundletool.py from unnecessarily outputting to STDOUT

bundletool.py calls the java bundle tool but also prints its output to
stdout. This is noise in the build log [1] which should only contain
errors and warning and should be empty otherwise.

[1] eg: building monochrome_public_minimal_apks outputs the entire
bundle manifest to stdout.

Change-Id: I2449c7bb5c93398afc18204932566801e385e4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031965Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737051}
parent 9da8f57f
...@@ -29,7 +29,6 @@ def RunBundleTool(args): ...@@ -29,7 +29,6 @@ def RunBundleTool(args):
logging.debug(' '.join(args)) logging.debug(' '.join(args))
return build_utils.CheckOutput( return build_utils.CheckOutput(
args, args,
print_stdout=True,
print_stderr=True, print_stderr=True,
stderr_filter=build_utils.FilterReflectiveAccessJavaWarnings) stderr_filter=build_utils.FilterReflectiveAccessJavaWarnings)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment